Skip to content

Commit 90b0765

Browse files
Remove test applicable only to rolling
Co-authored-by: Sai Kishor Kothakota <sai.kishor@pal-robotics.com>
1 parent 30f2248 commit 90b0765

File tree

1 file changed

+0
-43
lines changed

1 file changed

+0
-43
lines changed

controller_manager/test/test_controller_manager_srvs.cpp

Lines changed: 0 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -467,49 +467,6 @@ TEST_F(TestControllerManagerSrvs, unload_controller_srv)
467467
EXPECT_EQ(0u, cm_->get_loaded_controllers().size());
468468
}
469469

470-
TEST_F(TestControllerManagerSrvs, robot_description_on_load_and_unload_controller)
471-
{
472-
rclcpp::executors::SingleThreadedExecutor srv_executor;
473-
rclcpp::Node::SharedPtr srv_node = std::make_shared<rclcpp::Node>("srv_client");
474-
srv_executor.add_node(srv_node);
475-
rclcpp::Client<controller_manager_msgs::srv::UnloadController>::SharedPtr unload_client =
476-
srv_node->create_client<controller_manager_msgs::srv::UnloadController>(
477-
"test_controller_manager/unload_controller");
478-
479-
auto test_controller = std::make_shared<TestController>();
480-
auto abstract_test_controller = cm_->add_controller(
481-
test_controller, test_controller::TEST_CONTROLLER_NAME,
482-
test_controller::TEST_CONTROLLER_CLASS_NAME);
483-
EXPECT_EQ(1u, cm_->get_loaded_controllers().size());
484-
485-
// check the robot description
486-
ASSERT_EQ(ros2_control_test_assets::minimal_robot_urdf, test_controller->get_robot_description());
487-
488-
// Now change the robot description and then see that the controller maintains the old URDF until
489-
// it is unloaded and loaded again
490-
auto msg = std_msgs::msg::String();
491-
msg.data = ros2_control_test_assets::minimal_robot_missing_state_keys_urdf;
492-
cm_->robot_description_callback(msg);
493-
ASSERT_EQ(ros2_control_test_assets::minimal_robot_urdf, test_controller->get_robot_description());
494-
495-
// now unload and load the controller and see if the controller gets the new robot description
496-
auto unload_request = std::make_shared<controller_manager_msgs::srv::UnloadController::Request>();
497-
unload_request->name = test_controller::TEST_CONTROLLER_NAME;
498-
auto result = call_service_and_wait(*unload_client, unload_request, srv_executor, true);
499-
EXPECT_EQ(
500-
lifecycle_msgs::msg::State::PRIMARY_STATE_UNCONFIGURED, test_controller->get_state().id());
501-
EXPECT_EQ(0u, cm_->get_loaded_controllers().size());
502-
503-
// now load it and check if it got the new robot description
504-
cm_->add_controller(
505-
test_controller, test_controller::TEST_CONTROLLER_NAME,
506-
test_controller::TEST_CONTROLLER_CLASS_NAME);
507-
EXPECT_EQ(1u, cm_->get_loaded_controllers().size());
508-
ASSERT_EQ(
509-
ros2_control_test_assets::minimal_robot_missing_state_keys_urdf,
510-
test_controller->get_robot_description());
511-
}
512-
513470
TEST_F(TestControllerManagerSrvs, configure_controller_srv)
514471
{
515472
rclcpp::executors::SingleThreadedExecutor srv_executor;

0 commit comments

Comments
 (0)