Skip to content

Commit 085fc24

Browse files
committed
Add tests for disposing publishers, services, and clients
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
1 parent b16be6c commit 085fc24

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

rcljava/src/test/java/org/ros2/rcljava/client/ClientTest.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,16 @@ public final void testAdd() throws Exception {
111111
// Check the contents of the response
112112
assertEquals(5, response.getSum());
113113

114-
// Cleanup
114+
assertEquals(1, node.getClients().size());
115+
assertEquals(1, node.getServices().size());
116+
117+
// We expect that calling dispose should result in a zero handle
118+
// and the reference is dropped from the Node
115119
client.dispose();
116120
assertEquals(0, client.getHandle());
121+
assertEquals(0, node.getClients().size());
117122
service.dispose();
118123
assertEquals(0, service.getHandle());
124+
assertEquals(0, node.getServices().size());
119125
}
120126
}

rcljava/src/test/java/org/ros2/rcljava/publisher/PublisherTest.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,14 @@ public final void testCreate() {
3333
assertEquals(node.getHandle(), publisher.getNodeReference().get().getHandle());
3434
assertNotEquals(0, publisher.getNodeReference().get().getHandle());
3535
assertNotEquals(0, publisher.getHandle());
36+
assertEquals(1, node.getPublishers().size());
37+
38+
// We expect that calling dispose should result in a zero handle
39+
// and the reference is dropped from the Node
40+
publisher.dispose();
41+
assertEquals(0, publisher.getHandle());
42+
assertEquals(0, node.getPublishers().size());
43+
3644
RCLJava.shutdown();
3745
}
3846
}

0 commit comments

Comments
 (0)