Skip to content

Make the directory-finding substitutions into a PathSubstitution for / operator #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 5, 2025
Merged

Make the directory-finding substitutions into a PathSubstitution for / operator #914

merged 2 commits into from
Nov 5, 2025

Conversation

@emersonknapp
Copy link
Contributor

@emersonknapp emersonknapp commented Oct 23, 2025 •
edited
Loading

Description

Part of robograph-project/planning#38

Makes the two Substitutions that return a directory into a subclass of PathSubstitution

  • LaunchLogDir
  • ThisLaunchFileDir

So that one can immediately use the path join operator / with them.

Allows changing:

PathSubstitution(ThisLaunchFileDir()) / 'my_launch.py'
# or
PathJoinSubstitution([ThisLaunchFileDir(), 'my_launch.py'])

into

ThisLaunchFileDir() / 'my_launch.py'

Is this user-facing behavior change?

New user-facing capability, no existing usage changed.

Did you use Generative AI?

No

Additional Information

@emersonknapp emersonknapp moved this to In review in Robograph Planning Oct 23, 2025
@emersonknapp emersonknapp mentioned this pull request Oct 23, 2025
Merged
SuperJappie08
SuperJappie08 reviewed Oct 23, 2025
View reviewed changes
@ahcorde
Copy link
Contributor

ahcorde commented Oct 24, 2025

Pulls: #914, ros2/launch_ros#494
Gist: https://gist.githubusercontent.com/ahcorde/1d8541d31501406682d13767e15e788e/raw/cb7660853dbaea155933d8576f146a1a0d5953d6/ros2.repos
BUILD args: --packages-above-and-dependencies launch launch_ros test_launch_ros
TEST args: --packages-above launch launch_ros test_launch_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17368

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@emersonknapp
Make the directory-finding substitutions into a PathSubstitution for …
aca27dd 
…/ operator

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
make the super init arg explicit kw
47d9695 
Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Oct 28, 2025 •
edited
Loading

Pulls: #914, ros2/launch_ros#494
Gist: https://gist.githubusercontent.com/emersonknapp/2c725d3e9c99a8e2cd15f567470d1ada/raw/cb7660853dbaea155933d8576f146a1a0d5953d6/ros2.repos
BUILD args: --packages-above-and-dependencies launch launch_ros test_launch_ros
TEST args: --packages-above launch launch_ros test_launch_ros
ROS Distro: rolling
Job: ci_launcher
ci_launcher ran: https://ci.ros2.org/job/ci_launcher/17378

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
    • Build Status
  • Windows Build Status

@emersonknapp emersonknapp moved this to In review in ROSGraph Planning Oct 28, 2025
@ahcorde ahcorde merged commit 0d54476 into rolling Nov 5, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in ROSGraph Planning Nov 5, 2025
@github-project-automation github-project-automation bot moved this from In review to Done in Robograph Planning Nov 5, 2025
@ahcorde ahcorde deleted the emerson/path-subs branch November 5, 2025 18:01
@emersonknapp
Copy link
Contributor Author

emersonknapp commented Nov 5, 2025

@Mergifyio backport humble jazzy kilted

@mergify
Copy link

mergify bot commented Nov 5, 2025 •
edited
Loading

backport humble jazzy kilted

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 5, 2025
@emersonknapp @mergify
Make the directory-finding substitutions into a PathSubstitution for …
9eec31e 
…/ operator (#914)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 0d54476)

# Conflicts:
#	launch/launch/substitutions/launch_log_dir.py
#	launch/test/launch/substitutions/test_launch_log_dir.py
mergify bot pushed a commit that referenced this pull request Nov 5, 2025
@emersonknapp @mergify
Make the directory-finding substitutions into a PathSubstitution for …
6c617d9 
…/ operator (#914)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 0d54476)

# Conflicts:
#	launch/launch/substitutions/launch_log_dir.py
This was referenced Nov 5, 2025
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 5, 2025
@emersonknapp @mergify
Make the directory-finding substitutions into a PathSubstitution for …
148723c 
…/ operator (#914)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 0d54476)

# Conflicts:
#	launch/launch/substitutions/launch_log_dir.py
This was referenced Nov 5, 2025
Merged
Merged
Merged
Merged
ahcorde pushed a commit that referenced this pull request Nov 6, 2025
@mergify @emersonknapp
[backport jazzy] Make the directory-finding substitutions into a Path…
658ba9d 
…Substitution for / operator (backport #914) (#918)

Co-authored-by: Emerson Knapp <emerson.b.knapp@gmail.com>
ahcorde pushed a commit that referenced this pull request Nov 6, 2025
@mergify
[backport humble] Make the directory-finding substitutions into a Pat…
fe643ac 
…hSubstitution for / operator (backport #914) (#917)

* Make the directory-finding substitutions into a PathSubstitution for / operator (#914)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 0d54476)
ahcorde pushed a commit that referenced this pull request Nov 6, 2025
@mergify
[backport kilted] Make the directory-finding substitutions into a Pat…
748aadf 
…hSubstitution for / operator (backport #914) (#919)

* Make the directory-finding substitutions into a PathSubstitution for / operator (#914)

Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
(cherry picked from commit 0d54476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahcorde ahcorde ahcorde approved these changes

+1 more reviewer

@SuperJappie08 SuperJappie08 SuperJappie08 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@emersonknapp @ahcorde @SuperJappie08