Skip to content

Commit 95a6339

Browse files
Yuchen966mergify[bot]
authored andcommitted
correct test function descriptions (#2970)
Signed-off-by: Yuchen Liu <lyuchen9696@gmail.com> (cherry picked from commit 354413c) # Conflicts: # rclcpp/test/rclcpp/test_intra_process_manager.cpp
1 parent a9d1abe commit 95a6339

File tree

1 file changed

+40
-0
lines changed

1 file changed

+40
-0
lines changed

rclcpp/test/rclcpp/test_intra_process_manager.cpp

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -424,6 +424,7 @@ TEST(TestIntraProcessManager, add_pub_sub) {
424424
}
425425

426426
/*
427+
<<<<<<< HEAD
427428
This tests the minimal usage of the class where there is a single subscription per publisher:
428429
- Publishes a unique_ptr message with a subscription requesting ownership.
429430
- The received message is expected to be the same.
@@ -432,6 +433,16 @@ TEST(TestIntraProcessManager, add_pub_sub) {
432433
- The received message is expected to be the same, the first subscription do not receive it.
433434
- Publishes a shared_ptr message with a subscription not requesting ownership.
434435
- The received message is expected to be the same.
436+
=======
437+
* This tests the minimal usage of the class where there is a single subscription per publisher:
438+
* - Publishes a unique_ptr message with a subscription requesting ownership.
439+
* - The received message is expected to be the same.
440+
* - Remove the first subscription from ipm and add a new one.
441+
* - Publishes a unique_ptr message with a subscription not requesting ownership.
442+
* - The received message is expected to be the same, the first subscription do not receive it.
443+
* - Publishes a unique_ptr message with a subscription not requesting ownership.
444+
* - The received message is expected to be the same.
445+
>>>>>>> 354413c (correct test function descriptions (#2970))
435446
*/
436447
TEST(TestIntraProcessManager, single_subscription) {
437448
using IntraProcessManagerT = rclcpp::experimental::IntraProcessManager;
@@ -477,6 +488,7 @@ TEST(TestIntraProcessManager, single_subscription) {
477488
}
478489

479490
/*
491+
<<<<<<< HEAD
480492
This tests the usage of the class where there are multiple subscriptions of the same type:
481493
- Publishes a unique_ptr message with 2 subscriptions requesting ownership.
482494
- One is expected to receive the published message, while the other will receive a copy.
@@ -486,6 +498,17 @@ TEST(TestIntraProcessManager, single_subscription) {
486498
- Both received messages are expected to be a copy of the published one.
487499
- Publishes a shared_ptr message with 2 subscriptions not requesting ownership.
488500
- Both received messages are expected to be the same as the published one.
501+
=======
502+
* This tests the usage of the class where there are multiple subscriptions of the same type:
503+
* - Publishes a unique_ptr message with 2 subscriptions requesting ownership.
504+
* - One is expected to receive the published message, while the other will receive a copy.
505+
* - Publishes a unique_ptr message with 2 subscriptions not requesting ownership.
506+
* - Both received messages are expected to be the same as the published one.
507+
* - Publishes a unique_ptr message with 2 subscriptions requesting ownership.
508+
* - Both received messages are expected to be a copy of the published one.
509+
* - Publishes a unique_ptr message with 2 subscriptions not requesting ownership.
510+
* - Both received messages are expected to be the same as the published one.
511+
>>>>>>> 354413c (correct test function descriptions (#2970))
489512
*/
490513
TEST(TestIntraProcessManager, multiple_subscriptions_same_type) {
491514
using IntraProcessManagerT = rclcpp::experimental::IntraProcessManager;
@@ -578,6 +601,7 @@ TEST(TestIntraProcessManager, multiple_subscriptions_same_type) {
578601
}
579602

580603
/*
604+
<<<<<<< HEAD
581605
This tests the usage of the class where there are multiple subscriptions of different types:
582606
- Publishes a unique_ptr message with 1 subscription requesting ownership and 1 not.
583607
- The one requesting ownership is expected to receive the published message,
@@ -592,6 +616,22 @@ TEST(TestIntraProcessManager, multiple_subscriptions_same_type) {
592616
- Publishes a shared_ptr message with 1 subscription requesting ownership and 1 not.
593617
- The subscription requesting ownership is expected to receive a copy of the message, while
594618
the other is expected to receive the published message
619+
=======
620+
* This tests the usage of the class where there are multiple subscriptions of different types:
621+
* - Publishes a unique_ptr message with 1 subscription requesting ownership and 1 not.
622+
* - The one requesting ownership is expected to receive the published message,
623+
* while the other is expected to receive a copy.
624+
* - Publishes a unique_ptr message with 2 subscriptions requesting ownership and 1 not.
625+
* - One of the subscriptions requesting ownership is expected to receive the published message,
626+
* while both other subscriptions are expected to receive different copies.
627+
* - Publishes a unique_ptr message with 2 subscriptions requesting ownership and 2 not.
628+
* - The 2 subscriptions not requesting ownership are expected to both receive the same copy
629+
* of the message, one of the subscription requesting ownership is expected to receive a
630+
* different copy, while the last is expected to receive the published message.
631+
* - Publishes a unique_ptr message with 1 subscription requesting ownership and 1 not.
632+
* - The subscription requesting ownership is expected to receive the published message, while
633+
* the other is expected to receive a copy of the message
634+
>>>>>>> 354413c (correct test function descriptions (#2970))
595635
*/
596636
TEST(TestIntraProcessManager, multiple_subscriptions_different_type) {
597637
using IntraProcessManagerT = rclcpp::experimental::IntraProcessManager;

0 commit comments

Comments
 (0)