Skip to content

Commit b7c67ba

Browse files
committed
Add comment; removing logging
1 parent 66a9726 commit b7c67ba

File tree

5 files changed

+8
-9
lines changed

5 files changed

+8
-9
lines changed

inst/www/shared/shiny.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19072,10 +19072,8 @@
1907219072
enqueuedCount++;
1907319073
(_windowShiny$shinyapp = windowShiny3.shinyapp) === null || _windowShiny$shinyapp === void 0 ? void 0 : _windowShiny$shinyapp.actionQueue.enqueue(function() {
1907419074
enqueuedCount--;
19075-
console.log("enqueuedCount: ", enqueuedCount);
1907619075
if (enqueuedCount === 0) {
1907719076
var _windowShiny$bindAll;
19078-
console.log("REBIND!");
1907919077
(_windowShiny$bindAll = windowShiny3.bindAll) === null || _windowShiny$bindAll === void 0 ? void 0 : _windowShiny$bindAll.call(windowShiny3, document.documentElement);
1908019078
}
1908119079
});

inst/www/shared/shiny.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/www/shared/shiny.min.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/www/shared/shiny.min.js.map

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

srcts/src/shiny/init.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,16 +150,17 @@ function initShiny(windowShiny: Shiny): void {
150150
(x) => x.value
151151
);
152152

153+
// When future bindings are registered, rebind to the DOM once the current
154+
// event loop is done. This is necessary since the binding might be registered
155+
// after Shiny has already bound to the DOM (#3635)
153156
let enqueuedCount = 0;
154157
const enqueueRebind = () => {
155158
enqueuedCount++;
156159
windowShiny.shinyapp?.actionQueue.enqueue(() => {
157160
enqueuedCount--;
158-
console.log("enqueuedCount: ", enqueuedCount);
159161
// If this function is scheduled more than once in the queue, don't do anything.
160162
// Only do the bindAll when we get to the last instance of this function in the queue.
161163
if (enqueuedCount === 0) {
162-
console.log("REBIND!");
163164
windowShiny.bindAll?.(document.documentElement);
164165
}
165166
});

0 commit comments

Comments
 (0)