Skip redundant locale assignments in with_locale
#718
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If `tmp_locale&.to_sym == self.locale`, then temporarily reassigning `self.locale` is redundant. This small optimisation allows for early return when the locale is already set correctly.
aaronskiba
force-pushed
the
optimize-with_locale
branch
from
1b5b697 to
c64cf14
Compare
Author
|
I recently cleaned up several instances of That said, I realize the performance gain is likely negligible and may not justify the added conditionals. Feel free to close if it doesn't seem worthwhile. All the best. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
tmp_locale&.to_sym == self.locale, then temporarily reassigningself.localeis redundant. This small optimisation allows for early return when the locale is already set correctly.