🔍 Simplify Net::IMAP#inspect with basic state#612
Merged
Conversation
Most importantly, this no longer prints out *every* instance variable, some of which could contain sensitive data, and others are just _very_ verbose. Now `Net::IMAP#inspect` only prints the host:port, TLS state, and IMAP connection state. It will be extended to include more in the future.
nevans
force-pushed
the
simplified-inspect
branch
from
7924b25 to
2ae0bef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most importantly, this no longer prints out every instance variable, some of which could contain sensitive data, and others are just very verbose.
Now
Net::IMAP#inspectonly prints the host:port, TLS state, and IMAP connection state. It will be extended to include more information in the future.