Build releases with static CRT for -windows-msvc targets.
#21027
+12
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
ColinFinck
force-pushed
the
msvc-crt-static
branch
from
199e290 to
78cf393
Compare
This increases the binary size of `rust-analyzer.exe` from 42.4 MB to 42.6 MB. Which should be acceptable for eliminating 7 DLL dependencies.
ColinFinck
force-pushed
the
msvc-crt-static
branch
from
6d7ff66 to
6ec862a
Compare
Contributor
Author
|
CC @Veykril |
lnicola
approved these changes
Nov 25, 2025
Member
lnicola
left a comment
lnicola
left a comment
There was a problem hiding this comment.
I'm not a fan of this, but I'm also not a fan of how Windows doesn't ship the VC++ runtimes (probably for compatibility reasons).
rustbot
removed
the
S-waiting-on-review
|
This solves a huge issue with installing Rust through the standalone installers on Windows. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the binary size of
rust-analyzer.exefrom 42.4 MB to 42.6 MB.Which should be acceptable for eliminating 7 DLL dependencies.
Fixes #20970