fix Devices on linux, add keystation test

Author: briansorahan

keystation_test.go

@@ -0,0 +1,41 @@
+package midi
+
+import (
+	"fmt"
+	"strings"
+	"testing"
+)
+
+func TestKeystation(t *testing.T) {
+	devices, err := Devices()
+	if err != nil {
+		t.Fatal(err)
+	}
+	var keystation *Device
+	for _, d := range devices {
+		if strings.Contains(strings.ToLower(d.Name), "keystation") {
+			keystation = d
+			break
+		}
+	}
+	if keystation == nil {
+		t.Log("no keystation detected")
+		t.SkipNow()
+	}
+	fmt.Println("keystation detected")
+
+	if err := keystation.Open(); err != nil {
+		t.Fatal(err)
+	}
+	packets, err := keystation.Packets()
+	if err != nil {
+		t.Fatal(err)
+	}
+	i := 0
+	for pkt := range packets {
+		if i == 4 {
+			break
+		}
+		fmt.Printf("%#v\n", pkt)
+	}
+}

launchpad_test.go

@@ -13,7 +13,7 @@ func TestLaunchpad(t *testing.T) {
 	// The reason this package exists is because of issues that popped up when
 	// trying to use github.com/rakyll/portmidi to talk to the launchpad on Linux.
 	// For the launchpad MIDI reference, see https://d19ulaff0trnck.cloudfront.net/sites/default/files/novation/downloads/4080/launchpad-programmers-reference.pdf
-	// t.SkipNow()
+	t.SkipNow()
 
 	device := &Device{ID: "hw:0"}
 	if err := device.Open(); err != nil {

midi_linux.go

@@ -118,13 +118,14 @@ func Devices() ([]*Device, error) {
 		if err != nil {
 			return nil, err
 		}
+		devices = append(devices, cardDevices...)
+
 		if rc := C.snd_card_next(&card); rc != 0 {
 			return nil, alsaMidiError(rc)
 		}
 		if card < 0 {
 			break
 		}
-		devices = append(devices, cardDevices...)
 	}
 	return devices, nil
 }