Device Target Selection Fails When get_devices(mode="usb")

[kavefish]

Demo of working target selection via mode="serial":

In [44]: adb = ADB(adb_path="/opt/android/sdk/r24.4.1/platform-tools/adb")

In [45]: adb.get_devices()
Out[45]: (0, ['XXX', 'c'])

In [46]: adb.set_target_device("XXX")
Out[46]: True

In [47]: adb.shell_command("ls")
Out[47]: 'acct\r\ncache\r\nconfig\r\nd\r\ndata\r\ndefault.prop\r\ndev\r\netc\r\ninit\r\ninit.goldfish.rc\r\ninit.rc\r\ninit.sun5i.rc\r\ninit.sun5i.usb.rc\r\ninit.trace.rc\r\ninit.usb.rc\r\ninitlogo.rle\r\nmnt\r\nnand.ko\r\nproc\r\nroot\r\nsbin\r\nsdcard\r\nsys\r\nsystem\r\nueventd.goldfish.rc\r\nueventd.rc\r\nueventd.sun5i.rc\r\nvendor\r\n'

In [48]: adb.set_target_device("XXX")
Out[48]: True

In [49]: adb.shell_command("ls")
Out[49]: 'acct\ncache\ncharger\nconfig\nd\ndata\ndev\netc\nfirmware\nmnt\noem\nproc\nproperty_contexts\nres\nroot\nsbin\nsdcard\nstorage\nsys\nsystem\nvendor\n'

Demo of unsuccessful target selection with mode="usb":

In [50]: adb = ADB(adb_path="/opt/android/sdk/r24.4.1/platform-tools/adb")

In [51]: adb.get_devices(mode="usb")
Out[51]: (0, ['2-2', '2-1'])

In [52]: adb.set_target_device("2-2")
Out[52]: True

In [53]: adb.shell_command("ls")

In [54]: adb.get_error()
Out[54]: "error: device '2-2' not found\n"

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[sch3m4]

thanks for reporting, could you give it a try now?

[kavefish]

It looks like the behaviour of ADB.get_devices() has changed since I last looked. It no longer takes a mode argument to allow selection of a device by its USB bus identifier. So, it seems my patch is moot because the feature it fixed was removed.