Skip to content

Remove go-md2man package#96

Merged
phracek merged 2 commits intomainfrom
remove_go-md2man
Mar 17, 2026
Merged

Remove go-md2man package#96
phracek merged 2 commits intomainfrom
remove_go-md2man

Conversation

@phracek
Copy link
Member

@phracek phracek commented Mar 17, 2026

Remove go-md2man package.
We do not need it at all.

Summary by CodeRabbit

  • Chores
    • Removed a specific golang-related package from installation lists for Fedora, CentOS Stream 9, and CentOS Stream 10 to reduce dependency footprint.
    • Simplified CI/PR automation by removing hardware matrix entries and related variables, streamlining workflow configuration and automation logic.

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek
Copy link
Member Author

phracek commented Mar 17, 2026

[test]

@coderabbitai
Copy link

coderabbitai bot commented Mar 17, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 242a85ba-25cd-4f79-b28a-00836a9f964f

📥 Commits

Reviewing files that changed from the base of the PR and between a845e3c and e12ac5c.

📒 Files selected for processing (1)
  • .github/workflows/rpm-check.yaml

📝 Walkthrough

Walkthrough

Removed the golang-github-cpuguy83-md2man / go-md2man package from package lists in installer and test plan files, and simplified the RPM check workflow by removing hardware matrix entries and related variable usage. No other control flow changes introduced.

Changes

Cohort / File(s) Summary
Package dependency cleanup
roles/common_tools/tasks/main.yml, tmt-sclorg-testing-plan.yml
Deleted golang-github-cpuguy83-md2man (aka go-md2man) from Fedora, CentOS Stream 9 and CentOS Stream 10 package lists in installer tasks and test-plan package groups. No logic changes.
CI workflow simplification
.github/workflows/rpm-check.yaml
Removed matrix.tmt_hardware / matrix.hardware entries and references from job configuration and PR automation variables; dropped hardware suffix from composed OS variable.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Poem

🐰 I nibbled lines and cleared the view,
Pulled a package — out it flew,
Workflows lighter, lists made neat,
Little hops make code more sweet. 🥕✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Remove go-md2man package' directly and clearly describes the main change: removing the golang-github-cpuguy83-md2man (go-md2man) package from multiple package lists across configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove_go-md2man
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can disable the changed files summary in the walkthrough.

Disable the reviews.changed_files_summary setting to disable the changed files summary in the walkthrough.

@github-actions
Copy link

github-actions bot commented Mar 17, 2026

Testing Farm results

namecomposearchstatusstarted (UTC)timelogs
RPM check for presence in FedoraFedora-43x86_64❌ failed17.03.2026 10:06:426min 52stest pipeline
RPM check for presence in CentOS Stream 9CentOS-Stream-9x86_64✅ passed17.03.2026 10:06:428min 34stest pipeline
RPM check for presence in CentOS Stream 10CentOS-Stream-10x86_64✅ passed17.03.2026 10:07:029min 44stest pipeline

Signed-off-by: Petr "Stone" Hracek <phracek@redhat.com>
@phracek phracek merged commit 2c688cd into main Mar 17, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant