LLVMCodeBuilder: Do not free strings before suspending

adazem009 · adazem009 · commit 9b42803684ce · 2025-02-28T14:35:58.000+01:00
They're freed when the thread is destroyed.
diff --git a/src/engine/internal/llvm/llvmcodebuilder.cpp b/src/engine/internal/llvm/llvmcodebuilder.cpp
@@ -1022,7 +1022,6 @@ std::shared_ptr<ExecutableCode> LLVMCodeBuilder::finalize()
             }
 
             case LLVMInstruction::Type::Yield:
-                // TODO: Do not allow use after suspend (use after free)
                 createSuspend(coro.get(), warpArg, targetVariables);
                 break;
 
@@ -3167,7 +3166,6 @@ void LLVMCodeBuilder::createSuspend(LLVMCoroutine *coro, llvm::Value *warpArg, l
             m_builder.SetInsertPoint(suspendBranch);
         }
 
-        freeScopeHeap();
         syncVariables(targetVariables);
         coro->createSuspend();
         reloadVariables(targetVariables);

Original file line number	Diff line number	Diff line change
`@@ -1022,7 +1022,6 @@ std::shared_ptr<ExecutableCode> LLVMCodeBuilder::finalize()`
`1022`	`1022`	`}`
`1023`	`1023`
`1024`	`1024`	`case LLVMInstruction::Type::Yield:`
`1025`		`- // TODO: Do not allow use after suspend (use after free)`
`1026`	`1025`	`createSuspend(coro.get(), warpArg, targetVariables);`
`1027`	`1026`	`break;`
`1028`	`1027`
`@@ -3167,7 +3166,6 @@ void LLVMCodeBuilder::createSuspend(LLVMCoroutine coro, llvm::Value warpArg, l`
`3167`	`3166`	`m_builder.SetInsertPoint(suspendBranch);`
`3168`	`3167`	`}`
`3169`	`3168`
`3170`		`- freeScopeHeap();`
`3171`	`3169`	`syncVariables(targetVariables);`
`3172`	`3170`	`coro->createSuspend();`
`3173`	`3171`	`reloadVariables(targetVariables);`