code cleanup

Author: hero78119

ff_ext/Cargo.toml

@@ -13,8 +13,3 @@ version.workspace = true
 p3 = { path = "../p3" }
 rand_core.workspace = true
 serde.workspace = true
-
-[features]
-default = ["babybear"]
-babybear = []
-goldilocks = []

ff_ext/src/babybear.rs

@@ -92,8 +92,6 @@ pub mod impl_babybear {
     }
 
     impl PoseidonField for BabyBear {
-        const PERM_WIDTH: usize = POSEIDON2_BABYBEAR_WIDTH;
-        const RATE: usize = POSEIDON2_BABYBEAR_RATE;
         type P = Poseidon2BabyBear<POSEIDON2_BABYBEAR_WIDTH>;
         type T = DuplexChallenger<Self, Self::P, POSEIDON2_BABYBEAR_WIDTH, POSEIDON2_BABYBEAR_RATE>;
         fn get_perm() -> Self::T {

ff_ext/src/goldilock.rs

@@ -43,8 +43,6 @@ pub mod impl_goldilocks {
     pub const POSEIDON2_GOLDILICK_RATE: usize = 4;
 
     impl PoseidonField for Goldilocks {
-        const PERM_WIDTH: usize = POSEIDON2_GOLDILICK_WIDTH;
-        const RATE: usize = POSEIDON2_GOLDILICK_RATE;
         type P = Poseidon2GoldilocksHL<POSEIDON2_GOLDILICK_WIDTH>;
         type T =
             DuplexChallenger<Self, Self::P, POSEIDON2_GOLDILICK_WIDTH, POSEIDON2_GOLDILICK_RATE>;

ff_ext/src/lib.rs

@@ -121,9 +121,3 @@ pub trait ExtensionField: P3ExtensionField<Self::BaseField> + FromUniformBytes +
     /// Convert a field elements to a u64 vector
     fn to_canonical_u64_vec(&self) -> Vec<u64>;
 }
-
-// #[cfg(not(feature = "babybear"))]
-// pub trait ExtensionField: ExtensionFieldInner<8> {}
-
-// #[cfg(feature = "babybear")]
-// pub trait ExtensionField: ExtensionFieldInner<16> {}

ff_ext/src/poseidon.rs

@@ -14,8 +14,6 @@ pub trait FieldChallengerExt<F: PoseidonField>: FieldChallenger<F> {
 }
 
 pub trait PoseidonField: PrimeField + SmallField {
-    const PERM_WIDTH: usize;
-    const RATE: usize;
     type P: Clone;
     type T: FieldChallenger<Self> + Clone;
     fn get_perm() -> Self::T;

mpcs/src/lib.rs

@@ -1,5 +1,4 @@
 #![deny(clippy::cargo)]
-
 use ff_ext::ExtensionField;
 use itertools::Itertools;
 use multilinear_extensions::mle::DenseMultilinearExtension;
@@ -394,8 +393,6 @@ pub mod test_util {
     #[cfg(test)]
     use witness::RowMajorMatrix;
 
-    
-
     pub fn setup_pcs<E: ExtensionField, Pcs: PolynomialCommitmentScheme<E>>(
         num_vars: usize,
     ) -> (Pcs::ProverParam, Pcs::VerifierParam) {