-
Notifications
You must be signed in to change notification settings - Fork 857
test to reproduce out of order nonce #2447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (23.23%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
Additional details and impacted files@@ Coverage Diff @@
## main #2447 +/- ##
===========================================
- Coverage 51.48% 40.23% -11.26%
===========================================
Files 1541 1531 -10
Lines 156492 156303 -189
===========================================
- Hits 80572 62882 -17690
- Misses 69833 88708 +18875
+ Partials 6087 4713 -1374
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
b3385ce to
f4a9361
Compare
f4a9361 to
1105451
Compare
|
We truly appreciate your contribution and the time you’ve invested in this PR. |
Describe your changes and provide context
This PR includes the following changes:
CheckTxWrappedcall which is the same asCheckTxbut also returns the decoded transaction with all the derived fields to mempoolCheckNoncecall which is called per tx when proposer reaps from its mempool. Only transaction that passesCheckNoncewill be accepted. Note that for an honest validator, this step will never happen when nonces in states are changing (i.e commit and propose are two disjoint steps)CheckNoncein EVM keeperTesting performed to validate your change
unit tests
TODO: test in cluster