Skip to content

Conversation

@codchen
Copy link
Collaborator

@codchen codchen commented Oct 7, 2025

Describe your changes and provide context

This PR includes the following changes:

  • Added a new CheckTxWrapped call which is the same as CheckTx but also returns the decoded transaction with all the derived fields to mempool
  • Added a new CheckNonce call which is called per tx when proposer reaps from its mempool. Only transaction that passes CheckNonce will be accepted. Note that for an honest validator, this step will never happen when nonces in states are changing (i.e commit and propose are two disjoint steps)
  • Implemented CheckNonce in EVM keeper

Testing performed to validate your change

unit tests
TODO: test in cluster

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

❌ Patch coverage is 23.23232% with 76 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.23%. Comparing base (d9e851f) to head (1105451).
⚠️ Report is 625 commits behind head on main.

Files with missing lines Patch % Lines
app/abci.go 0.00% 24 Missing ⚠️
sei-tendermint/internal/mempool/mempool.go 0.00% 14 Missing ⚠️
sei-cosmos/baseapp/abci.go 20.00% 11 Missing and 1 partial ⚠️
sei-tendermint/internal/proxy/client.go 0.00% 6 Missing ⚠️
sei-tendermint/abci/client/grpc_client.go 0.00% 5 Missing ⚠️
sei-tendermint/abci/client/socket_client.go 0.00% 5 Missing ⚠️
sei-tendermint/abci/types/application.go 0.00% 4 Missing ⚠️
sei-tendermint/internal/consensus/replay_stubs.go 0.00% 4 Missing ⚠️
sei-tendermint/internal/state/execution.go 0.00% 1 Missing ⚠️
x/evm/keeper/keeper.go 95.23% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (23.23%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (47.20%) is below the target coverage (60.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (d9e851f) and HEAD (1105451). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (d9e851f) HEAD (1105451)
sei-tendermint 1 0
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2447       +/-   ##
===========================================
- Coverage   51.48%   40.23%   -11.26%     
===========================================
  Files        1541     1531       -10     
  Lines      156492   156303      -189     
===========================================
- Hits        80572    62882    -17690     
- Misses      69833    88708    +18875     
+ Partials     6087     4713     -1374     
Flag Coverage Δ
sei-chain 27.55% <20.20%> (-0.01%) ⬇️
sei-cosmos 51.63% <20.00%> (+0.21%) ⬆️
sei-tendermint ?
sei-wasmd 51.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
sei-tendermint/internal/mempool/tx.go 0.00% <ø> (-83.19%) ⬇️
sei-tendermint/internal/mempool/types.go 0.00% <ø> (ø)
sei-tendermint/internal/state/execution.go 0.00% <0.00%> (-60.10%) ⬇️
x/evm/keeper/keeper.go 58.85% <95.23%> (+1.92%) ⬆️
sei-tendermint/abci/types/application.go 0.00% <0.00%> (ø)
sei-tendermint/internal/consensus/replay_stubs.go 0.00% <0.00%> (-45.00%) ⬇️
sei-tendermint/abci/client/grpc_client.go 0.00% <0.00%> (ø)
sei-tendermint/abci/client/socket_client.go 0.00% <0.00%> (ø)
sei-tendermint/internal/proxy/client.go 0.00% <0.00%> (-21.14%) ⬇️
sei-cosmos/baseapp/abci.go 53.77% <20.00%> (-0.42%) ⬇️
... and 2 more

... and 186 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codchen codchen force-pushed the tony/mempool-pending-nonce-race branch from b3385ce to f4a9361 Compare October 9, 2025 05:10
@codchen codchen force-pushed the tony/mempool-pending-nonce-race branch from f4a9361 to 1105451 Compare October 9, 2025 05:15
@github-actions
Copy link

We truly appreciate your contribution and the time you’ve invested in this PR.
Before we can merge it, we’d love your help addressing the remaining feedback or sharing your perspective.
If we don’t hear back within 2 day(s), this PR will close automatically — but don’t worry, you can reopen it anytime when you’re ready to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants