handle FIN flag in order of the sequence numbers #2002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Changing base branch to |
Owner
|
@matthiasklein the |
Author
|
@seladb I corrected the number of messages in the test. The 31 extracted certificates still have exactly the same content. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2002 +/- ##
========================================
Coverage 83.45% 83.46%
========================================
Files 311 311
Lines 54578 54581 +3
Branches 11808 11607 -201
========================================
+ Hits 45549 45554 +5
+ Misses 7830 7794 -36
- Partials 1199 1233 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Matthias Klein <matthias@extraklein.de>
…ages count after TcpReassembly changes Note: the 31 extracted certificates still have exactly the same content. Signed-off-by: Matthias Klein <matthias@extraklein.de>
matthiasklein
force-pushed
the
tcpreassembly-data-frames-after-fin
branch
from
4866a54 to
8fb159b
Compare
Author
|
@seladb I have corrected the source code indentations that were complained about. Can you run the tests again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change resolves #1979
All 14 of my “faulty” transmissions that I had recorded are decoded correctly with this change.