Skip to content

fix: add break to skip dead loop in "transaction does not exist" #632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wangwq10 wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: add break to skip dead loop in "transaction does not exist" #632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/ccr/base/spec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1131,6 +1131,9 @@ func (s *Spec) WaitTransactionDone(txnId int64) {
for {
if err := s.waitTransactionDone(txnId); err != nil {
log.Errorf("wait transaction done failed, err +%v", err)
if strings.Contains(err.Error(), "does not exist") {
break
}
Comment on lines +1134 to +1136
Copy link
Contributor

@w41ter w41ter Jul 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping the waiting process by default is not recommended, as it may obscure critical issues. Could you implement a feature flag that is disabled by default?

time.Sleep(time.Second)
} else {
break
Expand Down
Loading