Commit 78b998e
committed
Vendor wcwidth using python's unicodedata
This commit replaces wcwidth dependency by a simple vendored module, leveraging
python's built-in unicodedata.
Notes:
1. `wcwidth()` function, provided by wcwidth library, is already decorated
with `lru_cache(100)`. Hence following line wraps lru-cached function into
another duplicated lru-cache layer, which may cause significant overhead.
wcwidth: Callable[[str], int] = lru_cache(maxsize=4096)(_wcwidth)
2. performance of vendored `wcwidth()` function is more or less equal to that
provided by `wcwidth` package.
3. this change turns pyte into a self-contained library.
4. only possible downside is supported unicode version being bound/limited to
that of used python interpreter. But that's probably rather minor as the
interpreter wouldn't be able to decode more recent unicode chars anyway.
Benchmarks:
>>> from timeit import timeit
>>> from wcwidth import wcswidth as wcswidth1
>>> from pyte.wcwidth import wcswidth2
>>> s = "开源的计算机代数系统 Maxima 是用于操纵符号和数值表达式的系统"
>>> timeit(lambda: wcswidth1(s))
7.851543699999999
>>> timeit(lambda: wcswidth2(s))
3.857342599999999
Credits:
The implementation is borrowed from pytest and slightly tweaked.1 parent 61d0c0c commit 78b998e
3 files changed
+66
-6
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | 49 | | |
53 | 50 | | |
54 | 51 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
42 | | - | |
43 | 41 | | |
44 | 42 | | |
45 | 43 | | |
46 | 44 | | |
47 | 45 | | |
48 | 46 | | |
49 | 47 | | |
| 48 | + | |
50 | 49 | | |
51 | | - | |
52 | 50 | | |
53 | 51 | | |
54 | 52 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
0 commit comments