Skip to content

Commit 3ecfed2

Browse files
Merge pull request #21 from zsajjad/fix-android-debug
fix: debug bundle issue for android API 28+
2 parents 0dd0412 + 3834755 commit 3ecfed2

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

android/app/src/main/java/com/reactnativesemaphorenew/MainApplication.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
import com.facebook.soloader.SoLoader;
1111
import java.lang.reflect.InvocationTargetException;
1212
import java.util.List;
13-
import com.facebook.react.BuildConfig;
1413

1514
public class MainApplication extends Application implements ReactApplication {
1615

package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
},
2323
"dependencies": {
2424
"react": "17.0.1",
25-
"react-native": "0.64.0-rc.1"
25+
"react-native": "0.64.0"
2626
},
2727
"devDependencies": {
2828
"@babel/core": "^7.8.4",
@@ -59,19 +59,19 @@
5959
"binaryPath": "ios/build/Build/Products/Debug-iphonesimulator/ReactNativeSemaphoreNew.app",
6060
"build": "xcodebuild ONLY_ACTIVE_ARCH=YES -workspace ios/ReactNativeSemaphoreNew.xcworkspace -scheme ReactNativeSemaphoreNew -configuration Debug -sdk iphonesimulator -derivedDataPath ios/build -UseModernBuildSystem=NO",
6161
"type": "ios.simulator",
62-
"name": "iPhone 8"
62+
"name": "iPhone 11"
6363
},
6464
"ios.sim.release": {
6565
"binaryPath": "ios/build/Build/Products/Release-iphonesimulator/ReactNativeSemaphoreNew.app",
6666
"build": "xcodebuild ONLY_ACTIVE_ARCH=YES -workspace ios/ReactNativeSemaphoreNew.xcworkspace -scheme ReactNativeSemaphoreNew -configuration Release -sdk iphonesimulator -derivedDataPath ios/build -UseModernBuildSystem=NO",
6767
"type": "ios.simulator",
68-
"name": "iPhone 8"
68+
"name": "iPhone 11"
6969
},
7070
"android.emu.debug": {
7171
"binaryPath": "android/app/build/outputs/apk/debug/app-debug.apk",
7272
"build": "cd android && ./gradlew assembleDebug assembleAndroidTest -DtestBuildType=debug && cd ..",
7373
"type": "android.emulator",
74-
"name": "Nexus_S_API_24"
74+
"name": "Pixel_4_API_28"
7575
},
7676
"android.emu.release": {
7777
"binaryPath": "android/app/build/outputs/apk/release/app-release.apk",

0 commit comments

Comments
 (0)