Skip to content

Conversation

@rmrustem
Copy link

@rmrustem rmrustem commented Nov 8, 2019

Pull Request Checklist

Is this in reference to an existing issue?

General

  • Update Changelog following the conventions laid out here

  • Update README with any necessary configuration snippets

  • Binstubs are created if needed

  • RuboCop passes

  • Existing tests pass

New Plugins

  • Tests

  • Add the plugin to the README

  • Does it have a complete header as outlined here

Purpose

  • Running the whole check with sudo may not be the optimal solution, so this PR adds an option to call specific commands and options with sudo.
  • Option to specify path to the MegaCli binary is added, as it can be installed into different location depending on the packages used.

Known Compatibility Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant