fix: changes needed for convo volatile wrapping

Author: Bilb

include/session/config/community.hpp

@@ -35,6 +35,8 @@ struct community {
     // Same as above, but takes pubkey as an encoded (hex or base32z or base64) string.
     community(std::string_view base_url, std::string_view room, std::string_view pubkey_encoded);
 
+    community(std::string full_url);
+
     // Takes a combined room URL (e.g. https://whatever.com/r/Room?public_key=01234....), either
     // new style (with /r/) or old style (without /r/).  Note that the URL gets canonicalized so
     // the resulting `base_url()` and `room()` values may not be exactly equal to what is given.

src/config/community.cpp

@@ -35,6 +35,10 @@ community::community(
     set_pubkey(pubkey_encoded);
 }
 
+community::community(std::string full_url) {
+    set_full_url(full_url);
+}
+
 void community::set_full_url(std::string_view full_url) {
     auto [b_url, r_token, s_pubkey] = parse_full_url(full_url);
     base_url_ = std::move(b_url);

src/config/groups/keys.cpp

@@ -657,7 +657,7 @@ Keys::swarm_auth Keys::swarm_subaccount_sign_as_user(
         std::span<const unsigned char> user_ed25519_sk,
         std::span<const unsigned char> msg,
         std::span<const unsigned char> sign_val,
-        bool binary) const {
+        bool binary) {
 
     if (sign_val.size() != 100)
         throw std::logic_error{"Invalid signing value: size is wrong"};
@@ -778,9 +778,11 @@ Keys::swarm_auth Keys::swarm_subaccount_sign(
         std::span<const unsigned char> msg,
         std::span<const unsigned char> sign_val,
         bool binary) const {
-    auto user_ed25519_sk_buf = this->user_ed25519_sk.data();
+    const unsigned char* user_ed25519_sk_buf = this->user_ed25519_sk.data();
+    std::span<const unsigned char> user_ed25519_sk(
+            user_ed25519_sk_buf, this->user_ed25519_sk.size());
 
-    return Keys::swarm_subaccount_sign_as_user(to_span(user_ed25519_sk_buf), msg, sign_val, binary);
+    return Keys::swarm_subaccount_sign_as_user(user_ed25519_sk, msg, sign_val, binary);
 }
 
 bool Keys::swarm_verify_subaccount(