fix: legacy option, remove cast task, readme (#6)

- Use --legacy option
- Update readme
- Remove cast from tasks

Author: snigdha920

.vscode/tasks.json

@@ -43,9 +43,9 @@
       "problemMatcher": []
     },
     {
-      "label": "deploy",
+      "label": "deploy-btp",
       "type": "shell",
-      "command": "EXTRA_ARGS=\"${input:extra-deployment-verify} ${input:extra-deployment-other}\" make deploy",
+      "command": "EXTRA_ARGS=\"${input:extra-deployment-verify} ${input:extra-deployment-other}\" make deploy-btp",
       "problemMatcher": []
     },
     {
@@ -60,12 +60,6 @@
       "command": "EXTRA_ARGS=\"${input:extra-script-broadcast} ${input:extra-script-other}\" make script",
       "problemMatcher": []
     },
-    {
-      "label": "cast",
-      "type": "shell",
-      "command": "make cast",
-      "problemMatcher": []
-    },
     {
       "label": "help",
       "type": "shell",

Makefile

@@ -26,23 +26,23 @@ deploy-anvil:
 	@echo "Deploying with Forge to Anvil..."
 	@forge create ./src/Counter.sol:Counter --rpc-url anvil --interactive | tee deployment-anvil.txt
 
-deploy:
+deploy-btp:
 	@eval $$(curl -H "x-auth-token: $${BTP_SERVICE_TOKEN}" -s $${BTP_CLUSTER_MANAGER_URL}/ide/foundry/$${BTP_SCS_ID}/env | sed 's/^/export /'); \
-	if [ -z "$${BTP_FROM}" ]; then \
+	args=""; \
+	if [ ! -z "$${BTP_FROM}" ]; then \
+		args="--unlocked --from $${BTP_FROM}"; \
+	else \
 		echo "\033[1;33mWARNING: No keys are activated on the node, falling back to interactive mode...\033[0m"; \
 		echo ""; \
-		if [ -z "$${BTP_GAS_PRICE}" ]; then \
-			forge create ./src/Counter.sol:Counter $${EXTRA_ARGS} --rpc-url $${BTP_RPC_URL} --interactive | tee deployment.txt; \
-		else \
-			forge create ./src/Counter.sol:Counter $${EXTRA_ARGS} --rpc-url $${BTP_RPC_URL} --interactive --gas-price $${BTP_GAS_PRICE} | tee deployment.txt; \
-		fi; \
-	else \
-		if [ -z "$${BTP_GAS_PRICE}" ]; then \
-			forge create ./src/Counter.sol:Counter $${EXTRA_ARGS} --rpc-url $${BTP_RPC_URL} --unlocked --from $${BTP_FROM} | tee deployment.txt; \
-		else \
-			forge create ./src/Counter.sol:Counter $${EXTRA_ARGS} --rpc-url $${BTP_RPC_URL} --unlocked --from $${BTP_FROM} --gas-price $${BTP_GAS_PRICE} | tee deployment.txt; \
-		fi; \
-	fi
+		args="--interactive"; \
+	fi; \
+	if [ ! -z "$${BTP_GAS_PRICE}" ]; then \
+		args="$$args --gas-price $${BTP_GAS_PRICE}"; \
+	fi; \
+	if [ "$${BTP_EIP_1559_ENABLED}" = "false" ]; then \
+		args="$$args --legacy"; \
+	fi; \
+	forge create ./src/Counter.sol:Counter $${EXTRA_ARGS} --rpc-url $${BTP_RPC_URL} $$args --constructor-args "GenericToken" "GT" | tee deployment.txt;
 
 script-anvil:
 	@if [ ! -f deployment-anvil.txt ]; then \
@@ -52,8 +52,8 @@ script-anvil:
 	@DEPLOYED_ADDRESS=$$(grep "Deployed to:" deployment-anvil.txt | awk '{print $$3}') forge script script/Counter.s.sol:CounterScript ${EXTRA_ARGS} --rpc-url anvil -i=1
 
 script:
-	@if [ ! -f deployment-anvil.txt ]; then \
-		echo "\033[1;31mERROR: Contract was not deployed or the deployment-anvil.txt went missing.\033[0m"; \
+	@if [ ! -f deployment.txt ]; then \
+		echo "\033[1;31mERROR: Contract was not deployed or the deployment.txt went missing.\033[0m"; \
 		exit 1; \
 	fi
 	@eval $$(curl -H "x-auth-token: $${BTP_SERVICE_TOKEN}" -s $${BTP_CLUSTER_MANAGER_URL}/ide/foundry/$${BTP_SCS_ID}/env | sed 's/^/export /'); \

README.md

@@ -70,12 +70,16 @@ Deploy to a local anvil node:
 $ make deploy-anvil
 ```
 
+When prompted to enter a private key, copy one of the private keys shown in the terminal when you start the anvil node.
+
 Deploy to the connected platform node:
 
 ```shell
 $ make deploy-btp
 ```
 
+If you have a private key activated on the connected node, it will be used automatically. Else, you will be prompted to enter a private key. You can copy-paste a private key from the platform.
+
 ### Cast
 
 ```shell