node bandwidth vs. tor bandwidthrate

[stef-roos]

It seems like the tor bandwidthrate can exceed the download/upload bandwidth of a node, e.g., the following results in a relay node with 1miB/s bandwidth

<node id="relay1" bandwidthdown="0" bandwidthup="0">

[robgjansen]

This is because a value of 0 is invalid for bandwidthdown and bandwidthup - in this case the node gets assigned the bandwidth of the topology vertex to which is was assigned (instead of 0 bandwidth). If you set those bandwidth parameters to 1 instead of 0, my guess is that it will work as you expect.

[robgjansen]

Hey @stef-roos, can you let me know if bandwidth=1 works as you expect here, so we can close this issue?

(BTW, if you'd like to argue that bandwidth=0 should be allowed as a valid input, please open a separate ticket on the shadow issue tracker to request that change.)

[robgjansen]

Perhaps if the user specifies a 0 bandwidth, the config file validator should indicate that the config file is invalid, in which case the experiment will not proceed.