Skip to content

gitcrypt (0.3.0, 0.3.1, 0.3.2) did not work with git v2.2.x #48

@hoatle

Description

@hoatle

I checked with the following git versions:

git v1.9.5: ok
git v2.0.0: ok
git v2.0.5: ok
git v2.1.4: ok

git v2.2.0, v2.2.1, v2.2.2: NOT ok

I checked with git-encrypt v0.3.0, v0.3.1 and v0.3.2, the problem was the same.

Steps to reproduce:

vagrant@vagrant:~/workspace/personal$ git --version
git version 2.2.0
vagrant@vagrant:~/workspace/personal$ gitcrypt version
gitcrypt version 0.3.0
vagrant@vagrant:~/workspace/personal$ mkdir test
vagrant@vagrant:~/workspace/personal$ cd test/
vagrant@vagrant:~/workspace/personal/test$ git init
Initialized empty Git repository in /home/vagrant/workspace/personal/test/.git/
vagrant@vagrant:~/workspace/personal/test$ touch README.md
vagrant@vagrant:~/workspace/personal/test$ gitcrypt init
Generate a random salt? [Y/n] 
Generate a random password? [Y/n]n
Enter your passphrase: 123456
What encryption cipher do you want to use? [aes-256-ecb] 

This configuration will be stored:

salt:   1f144788937c915a
pass:   123456
cipher: aes-256-ecb

Does this look right? [Y/n] 
Do you want to use .git/info/attributes? [Y/n] n
What files do you want encrypted? [*] 
vagrant@vagrant:~/workspace/personal/test$ git status
On branch master

Initial commit

Untracked files:
  (use "git add <file>..." to include in what will be committed)

    .gitattributes
    README.md

nothing added to commit but untracked files present (use "git add" to track)
vagrant@vagrant:~/workspace/personal/test$ git add .
error: copy-fd: read returned Bad file descriptor
error: cannot feed the input to external filter gitcrypt clean
error: external filter gitcrypt clean failed

as we could see, when I $ git add, we got the following messages:

error: copy-fd: read returned Bad file descriptor
error: cannot feed the input to external filter gitcrypt clean
error: external filter gitcrypt clean failed

So before a fix for this is updated, we will need to use the working git versions tested above.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions