Skip to content

Remove Bitcoin Cash from SegWit script type support matrix #740

@coderabbitai

Description

@coderabbitai

Context

Bitcoin Cash does not support SegWit (neither P2SH-P2WPKH nor native SegWit). However, the btcSupportsScriptType method in packages/hdwallet-gridplus/src/gridplus.ts (lines ~87-98) incorrectly includes "BitcoinCash" in the arrays for:

  • core.BTCInputScriptType.SpendP2SHWitness
  • core.BTCInputScriptType.SpendWitness

Required Change

Remove "BitcoinCash" from both SegWit script type cases, leaving it only in the SpendAddress (legacy P2PKH) case.

References

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions