PHP 7.2 breaks unmanaged dependency

[stephenswat]

While installing Keepstar on a machine with PHP 7.2 I noticed that the software does not work. After a little bit of investigation I realised that this is because Guzzle 6.2 is included in /libraries/ (without being managed by Composer). PHP 7.2 changes the count function which means Guzzle 6.2 is incompatible with it (guzzle/guzzle#1686). Guzzle >= 6.3.0 is compatible.

Please, if you can, either add a note that Keepstar requires PHP 7.0 or 7.1 (and not >=7.2), remove the unmanaged dependency and have it managed by Composer or update the version of Guzzle included in the source tree.

[ppfeufer]

With PHP7.0 being end of life and 7.1 out of maintenance, I suggest updateing Guzzle is the ideal and only way to solve this issue

https://secure.php.net/supported-versions.php

[steven-cmy]

can confirm this.

[Neodork]

I agree with @stephenswat for adding the guzzle dependency in composer.

I did it in my fork (currently no time for PR). And it works fine, you just need to remove the additional autoloader line.

[w33ts]

@Neodork Where is this additional autoloader line location?

[Neodork]

@DashieSystems Think I eventually decided to not do that but instead just add the library using composer instead. You can check the fork I have in my profile. It's been a long time since I implemented this solution.