Merge pull request #2 from shrink/feature/static-analysis

Add Static Analysis as part of the code quality standards

Author: shrink

.env.example

@@ -7,17 +7,3 @@ APP_DEBUG=true
 APP_URL=http://localhost
 
 LOG_CHANNEL=stack
-
-DB_CONNECTION=mysql
-DB_HOST=127.0.0.1
-DB_PORT=3306
-DB_DATABASE=laravel
-DB_USERNAME=root
-DB_PASSWORD=
-
-MAIL_DRIVER=smtp
-MAIL_HOST=127.0.0.1
-MAIL_PORT=1025
-MAIL_USERNAME=null
-MAIL_PASSWORD=null
-MAIL_ENCRYPTION=null

Dockerfile

@@ -42,7 +42,7 @@ COPY . /srv
 RUN composer dump-autoload
 
 FROM dependencies as test
-RUN composer check
+RUN composer quality
 
 FROM dependencies as clean
 RUN composer install --no-dev

SCAFFOLD.md

@@ -1,6 +1,6 @@
 # Laravel Scaffold
 
-The Laravel Scaffold is a Laravel `v6` install with a number of helpful
+The Laravel Scaffold is a Laravel `v7` install with a number of helpful
 development lifecycle features like coding standards added and much of the
 Laravel boilerplate removed -- all remaining boilerplate has been updated to
 pass validation.
@@ -27,7 +27,7 @@ complete the following steps:
 * Aliases have been removed from `config/app.php` as they encourage bad
   practices by bypassing dependency injection
 * The `routes/` directory has been removed in favour of explicit route
-  registration through the `HttpServiceProvider` as this encourages developers
+  registration through a `ServiceProvider` as this encourages developers
   to think about HTTP as one interface into the application(s) of many rather
   than _the_ application
 

composer.json

@@ -13,7 +13,8 @@
         "facade/ignition": "^2.0",
         "nunomaduro/collision": "^4.1",
         "nunomaduro/phpinsights": "^1.14",
-        "phpunit/phpunit": "^8.5|^9.0"
+        "phpunit/phpunit": "^8.5|^9.0",
+        "vimeo/psalm": "^3.11"
     },
     "config": {
         "optimize-autoloader": false,
@@ -57,13 +58,17 @@
         ],
         "quality": [
             "@test",
+            "@static",
             "@insights"
         ],
         "test": [
             "vendor/bin/phpunit --colors=always"
         ],
         "insights": [
             "@php artisan insights --ansi --no-interaction --config-path=config/insights.php"
+        ],
+        "static": [
+            "vendor/bin/psalm --long-progress"
         ]
     }
 }