Skip to content

Conversation

@ianrahman
Copy link

@ianrahman ianrahman commented Oct 28, 2025

First time contributor checklist

Contributor checklist

  • My commits are rebased on the latest main branch
  • My commits are in nice logical chunks
  • My contribution is fully baked and is ready to be merged as is
  • I have tested my contribution on these devices:
  • iPhone 16 Pro Max, iOS 26.1 b4

Addresses #4370

Description

  • retry AVAsset exports across presets and map AVError.maximumFileSizeReached to .fileSizeTooLarge
  • enforce preset dimension limits based on bitrate estimates and annotate the heuristics we rely on
  • add shared helpers for export error detection and size/quality guardrails
  • made media file size limits consistent and removed hardcoded calculations for static values

Testing

  • Attached a large (> 100 MB) video file to a message and successfully sent to a non-dev device. Received video size was < 100 MB and video quality was significantly better than same video attached and sent with current production implementation.

@ianrahman ianrahman mentioned this pull request Oct 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant