Skip to content

Commit 7a8e7bb

Browse files
committed
fix UrlTrait::validate call test for the different methods.
1 parent 8c9a764 commit 7a8e7bb

File tree

1 file changed

+20
-5
lines changed

1 file changed

+20
-5
lines changed

tests/src/Controller/Cas20ControllerTest.php

Lines changed: 20 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -111,13 +111,28 @@ protected function setUp(): void
111111
];
112112
}
113113

114-
public function testProxyValidatePassesTheCorrectMethodToValidate(): void
114+
public static function validateMethods(): array
115+
{
116+
return [
117+
'Call serviceValidate action' => [
118+
'ST-',
119+
'serviceValidate',
120+
],
121+
'Call proxyValidate action' => [
122+
'PT-',
123+
'proxyValidate',
124+
],
125+
];
126+
}
127+
128+
#[DataProvider('validateMethods')]
129+
public function testProxyValidatePassesTheCorrectMethodToValidate(string $prefix, string $method): void
115130
{
116131
$casconfig = Configuration::loadFromArray($this->moduleConfig);
117132
$requestParameters = [
118133
'renew' => false,
119134
'service' => 'https://myservice.com/abcd',
120-
'ticket' => 'ST-' . $this->sessionId,
135+
'ticket' => $prefix . $this->sessionId,
121136
];
122137

123138
$request = Request::create(
@@ -127,10 +142,10 @@ public function testProxyValidatePassesTheCorrectMethodToValidate(): void
127142

128143
$expectedArguments = [
129144
'request' => $request,
130-
'method' => 'proxyValidate',
145+
'method' => $method,
131146
'renew' => false,
132147
'target' => null,
133-
'ticket' => 'ST-' . $this->sessionId,
148+
'ticket' => $prefix . $this->sessionId,
134149
'service' => 'https://myservice.com/abcd',
135150
'pgtUrl' => null,
136151
];
@@ -142,7 +157,7 @@ public function testProxyValidatePassesTheCorrectMethodToValidate(): void
142157

143158
$controllerMock->expects($this->once())->method('validate')
144159
->with(...$expectedArguments);
145-
$controllerMock->proxyValidate($request, ...$requestParameters);
160+
$controllerMock->$method($request, ...$requestParameters);
146161
}
147162

148163
public static function queryParameterValues(): array

0 commit comments

Comments
 (0)