ack comments

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/logs/components/log-details/components/execution-snapshot/execution-snapshot.tsx

@@ -28,17 +28,11 @@ interface BlockExecutionData {
   durationMs: number
 }
 
-/**
- * Migrated logs have special properties to indicate they came from the old logging system
- */
 interface MigratedWorkflowState extends WorkflowState {
   _migrated: true
   _note?: string
 }
 
-/**
- * Type guard to check if a workflow state is from a migrated log
- */
 function isMigratedWorkflowState(state: WorkflowState): state is MigratedWorkflowState {
   return (state as MigratedWorkflowState)._migrated === true
 }
@@ -67,7 +61,6 @@ export function ExecutionSnapshot({
   const { data, isLoading, error } = useExecutionSnapshot(executionId)
   const [pinnedBlockId, setPinnedBlockId] = useState<string | null>(null)
 
-  // Process traceSpans to create blockExecutions map
   const blockExecutions = useMemo(() => {
     if (!traceSpans || !Array.isArray(traceSpans)) return {}
 
@@ -104,7 +97,6 @@ export function ExecutionSnapshot({
     return blockExecutionMap
   }, [traceSpans])
 
-  // Reset pinned block when executionId changes
   useEffect(() => {
     setPinnedBlockId(null)
   }, [executionId])
@@ -189,7 +181,6 @@ export function ExecutionSnapshot({
             defaultPosition={{ x: 0, y: 0 }}
             defaultZoom={0.8}
             onNodeClick={(blockId) => {
-              // Toggle: clicking same block closes sidebar, clicking different block switches
               setPinnedBlockId((prev) => (prev === blockId ? null : blockId))
             }}
             cursorStyle='pointer'
@@ -211,7 +202,15 @@ export function ExecutionSnapshot({
 
   if (isModal) {
     return (
-      <Modal open={isOpen} onOpenChange={(open) => !open && onClose()}>
+      <Modal
+        open={isOpen}
+        onOpenChange={(open) => {
+          if (!open) {
+            setPinnedBlockId(null)
+            onClose()
+          }
+        }}
+      >
         <ModalContent size='full' className='flex h-[90vh] flex-col'>
           <ModalHeader>Workflow State</ModalHeader>
 

apps/sim/app/workspace/[workspaceId]/logs/logs.tsx

@@ -93,7 +93,6 @@ export default function Logs() {
   const [isPreviewOpen, setIsPreviewOpen] = useState(false)
   const [previewLogId, setPreviewLogId] = useState<string | null>(null)
 
-  // Single query for the "active" log detail - used by both sidebar and preview
   const activeLogId = isPreviewOpen ? previewLogId : selectedLogId
   const activeLogQuery = useLogDetail(activeLogId ?? undefined)
 
@@ -141,14 +140,12 @@ export default function Logs() {
     return logsQuery.data.pages.flatMap((page) => page.logs)
   }, [logsQuery.data?.pages])
 
-  // Derive selected log and index from the logs array
   const selectedLogIndex = useMemo(
     () => (selectedLogId ? logs.findIndex((l) => l.id === selectedLogId) : -1),
     [logs, selectedLogId]
   )
   const selectedLogFromList = selectedLogIndex >= 0 ? logs[selectedLogIndex] : null
 
-  // Merge list data with detail query data for sidebar
   const selectedLog = useMemo(() => {
     if (!selectedLogFromList) return null
     if (!activeLogQuery.data || isPreviewOpen) return selectedLogFromList
@@ -163,7 +160,6 @@ export default function Logs() {
     }
   }, [debouncedSearchQuery, setStoreSearchQuery])
 
-  // Refetch detail when live mode is active
   useEffect(() => {
     if (!isLive || !selectedLogId) return
     const interval = setInterval(() => activeLogQuery.refetch(), 5000)
@@ -363,7 +359,6 @@ export default function Logs() {
       if (isSearchOpenRef.current) return
       if (logs.length === 0) return
 
-      // Select first log if none selected and arrow key pressed
       if (selectedLogIndex === -1 && (e.key === 'ArrowUp' || e.key === 'ArrowDown')) {
         e.preventDefault()
         setSelectedLogId(logs[0].id)

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/deploy/components/deploy-modal/components/general/general.tsx

@@ -64,10 +64,8 @@ export function GeneralDeploy({
   const versionToPromoteInfo = versions.find((v) => v.version === versionToPromote)
   const versionToLoadInfo = versions.find((v) => v.version === versionToLoad)
 
-  // React Query for fetching selected version state (with caching)
   const { data: selectedVersionState } = useDeploymentVersionState(workflowId, selectedVersion)
 
-  // React Query mutation for reverting to a version
   const revertMutation = useRevertToVersion()
 
   useEffect(() => {
@@ -95,7 +93,6 @@ export function GeneralDeploy({
   const confirmLoadDeployment = async () => {
     if (!workflowId || versionToLoad === null) return
 
-    // Close modal immediately for snappy UX
     setShowLoadDialog(false)
     const version = versionToLoad
     setVersionToLoad(null)
@@ -111,7 +108,6 @@ export function GeneralDeploy({
   const confirmPromoteToLive = async () => {
     if (versionToPromote === null) return
 
-    // Close modal immediately for snappy UX
     setShowPromoteDialog(false)
     const version = versionToPromote
     setVersionToPromote(null)
@@ -132,7 +128,6 @@ export function GeneralDeploy({
 
   const showToggle = selectedVersion !== null && deployedState
 
-  // Only show skeleton on initial load when we have no deployed data
   const hasDeployedData = deployedState && Object.keys(deployedState.blocks || {}).length > 0
   const showLoadingSkeleton = isLoadingDeployedState && !hasDeployedData
 

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-edge/workflow-edge.tsx

@@ -55,13 +55,11 @@ const WorkflowEdgeComponent = ({
 
   const dataSourceHandle = (data as { sourceHandle?: string } | undefined)?.sourceHandle
   const isErrorEdge = (sourceHandle ?? dataSourceHandle) === 'error'
-  // Check for execution status from both live execution store and preview data
   const previewExecutionStatus = (
     data as { executionStatus?: 'success' | 'error' | 'not-executed' } | undefined
   )?.executionStatus
   const edgeRunStatus = previewExecutionStatus || lastRunEdges.get(id)
 
-  // Memoize diff status calculation to avoid recomputing on every render
   const edgeDiffStatus = useMemo((): EdgeDiffStatus => {
     if (data?.isDeleted) return 'deleted'
     if (!diffAnalysis?.edge_diff || !isDiffReady) return null
@@ -88,7 +86,6 @@ const WorkflowEdgeComponent = ({
     targetHandle,
   ])
 
-  // Memoize edge style to prevent object recreation
   const edgeStyle = useMemo(() => {
     let color = 'var(--workflow-edge)'
     let opacity = 1
@@ -160,7 +157,6 @@ const WorkflowEdgeComponent = ({
               e.stopPropagation()
 
               if (data?.onDelete) {
-                // Pass this specific edge's ID to the delete function
                 data.onDelete(id)
               }
             }}

apps/sim/app/workspace/[workspaceId]/w/components/preview/components/block-details-sidebar.tsx

@@ -1,6 +1,6 @@
 'use client'
 
-import { useMemo, useState } from 'react'
+import { useEffect, useMemo, useState } from 'react'
 import { ChevronDown as ChevronDownIcon, X } from 'lucide-react'
 import { ReactFlowProvider } from 'reactflow'
 import { Badge, Button, ChevronDown, Code } from '@/components/emcn'
@@ -210,10 +210,11 @@ function ExecutionDataSection({ title, data, isError = false }: ExecutionDataSec
  */
 function ResolvedConnectionsSection({ connections }: { connections: ResolvedConnection[] }) {
   const [isCollapsed, setIsCollapsed] = useState(false)
-  const [expandedBlocks, setExpandedBlocks] = useState<Set<string>>(() => {
-    // Start with all blocks expanded
-    return new Set(connections.map((c) => c.blockId))
-  })
+  const [expandedBlocks, setExpandedBlocks] = useState<Set<string>>(new Set())
+
+  useEffect(() => {
+    setExpandedBlocks(new Set(connections.map((c) => c.blockId)))
+  }, [connections])
 
   if (connections.length === 0) return null