Skip to content

Commit 08e3cc8

Browse files
committed
consolidated utils
1 parent f0cb711 commit 08e3cc8

File tree

4 files changed

+20
-31
lines changed

4 files changed

+20
-31
lines changed

apps/sim/app/api/mcp/workflow-servers/[id]/tools/route.ts

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,24 +6,10 @@ import type { NextRequest } from 'next/server'
66
import { getParsedBody, withMcpAuth } from '@/lib/mcp/middleware'
77
import { createMcpErrorResponse, createMcpSuccessResponse } from '@/lib/mcp/utils'
88
import { sanitizeToolName } from '@/lib/mcp/workflow-tool-schema'
9-
import { loadWorkflowFromNormalizedTables } from '@/lib/workflows/persistence/utils'
10-
import { hasValidStartBlockInState } from '@/lib/workflows/triggers/trigger-utils'
9+
import { hasValidStartBlock } from '@/lib/workflows/triggers/trigger-utils.server'
1110

1211
const logger = createLogger('WorkflowMcpToolsAPI')
1312

14-
/**
15-
* Check if a workflow has a valid start block by loading from database
16-
*/
17-
async function hasValidStartBlock(workflowId: string): Promise<boolean> {
18-
try {
19-
const normalizedData = await loadWorkflowFromNormalizedTables(workflowId)
20-
return hasValidStartBlockInState(normalizedData)
21-
} catch (error) {
22-
logger.warn('Error checking for start block:', error)
23-
return false
24-
}
25-
}
26-
2713
export const dynamic = 'force-dynamic'
2814

2915
interface RouteParams {

apps/sim/app/api/mcp/workflow-servers/route.ts

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ import type { NextRequest } from 'next/server'
66
import { getParsedBody, withMcpAuth } from '@/lib/mcp/middleware'
77
import { createMcpErrorResponse, createMcpSuccessResponse } from '@/lib/mcp/utils'
88
import { sanitizeToolName } from '@/lib/mcp/workflow-tool-schema'
9-
import { loadWorkflowFromNormalizedTables } from '@/lib/workflows/persistence/utils'
10-
import { hasValidStartBlockInState } from '@/lib/workflows/triggers/trigger-utils'
9+
import { hasValidStartBlock } from '@/lib/workflows/triggers/trigger-utils.server'
1110

1211
const logger = createLogger('WorkflowMcpServersAPI')
1312

@@ -80,19 +79,6 @@ export const GET = withMcpAuth('read')(
8079
}
8180
)
8281

83-
/**
84-
* Check if a workflow has a valid start block by loading from database
85-
*/
86-
async function hasValidStartBlock(workflowId: string): Promise<boolean> {
87-
try {
88-
const normalizedData = await loadWorkflowFromNormalizedTables(workflowId)
89-
return hasValidStartBlockInState(normalizedData)
90-
} catch (error) {
91-
logger.warn('Error checking for start block:', error)
92-
return false
93-
}
94-
}
95-
9682
/**
9783
* POST - Create a new workflow MCP server
9884
*/
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import { createLogger } from '@sim/logger'
2+
import { loadWorkflowFromNormalizedTables } from '@/lib/workflows/persistence/utils'
3+
import { hasValidStartBlockInState } from '@/lib/workflows/triggers/trigger-utils'
4+
5+
const logger = createLogger('TriggerUtils')
6+
7+
/**
8+
* Check if a workflow has a valid start block by loading from database
9+
*/
10+
export async function hasValidStartBlock(workflowId: string): Promise<boolean> {
11+
try {
12+
const normalizedData = await loadWorkflowFromNormalizedTables(workflowId)
13+
return hasValidStartBlockInState(normalizedData)
14+
} catch (error) {
15+
logger.warn('Error checking for start block:', error)
16+
return false
17+
}
18+
}

apps/sim/lib/workflows/triggers/trigger-utils.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,6 @@ function generateMockValue(type: string, _description?: string, fieldName?: stri
9090
* Recursively processes nested output structures
9191
*/
9292
function processOutputField(key: string, field: unknown, depth = 0, maxDepth = 10): unknown {
93-
// Prevent infinite recursion
9493
if (depth > maxDepth) {
9594
return null
9695
}

0 commit comments

Comments
 (0)