Skip to content

Commit 33d3a2c

Browse files
committed
fix trigger vs block scoping
1 parent 1566c6f commit 33d3a2c

File tree

2 files changed

+16
-10
lines changed

2 files changed

+16
-10
lines changed

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/editor.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -97,12 +97,7 @@ export function Editor() {
9797
)
9898
)
9999

100-
const canonicalIndex = useMemo(
101-
() => buildCanonicalIndex(blockConfig?.subBlocks || []),
102-
[blockConfig?.subBlocks]
103-
)
104-
const canonicalModeOverrides = currentBlock?.data?.canonicalModes
105-
const subBlocksForAdvancedCheck = useMemo(() => {
100+
const subBlocksForCanonical = useMemo(() => {
106101
const subBlocks = blockConfig?.subBlocks || []
107102
if (!triggerMode) return subBlocks
108103
return subBlocks.filter(
@@ -111,16 +106,21 @@ export function Editor() {
111106
)
112107
}, [blockConfig?.subBlocks, triggerMode])
113108

109+
const canonicalIndex = useMemo(
110+
() => buildCanonicalIndex(subBlocksForCanonical),
111+
[subBlocksForCanonical]
112+
)
113+
const canonicalModeOverrides = currentBlock?.data?.canonicalModes
114114
const advancedValuesPresent = hasAdvancedValues(
115-
subBlocksForAdvancedCheck,
115+
subBlocksForCanonical,
116116
blockSubBlockValues,
117117
canonicalIndex
118118
)
119119
const displayAdvancedOptions = advancedMode || advancedValuesPresent
120120

121121
const hasAdvancedOnlyFields = useMemo(
122-
() => hasStandaloneAdvancedFields(subBlocksForAdvancedCheck, canonicalIndex),
123-
[subBlocksForAdvancedCheck, canonicalIndex]
122+
() => hasStandaloneAdvancedFields(subBlocksForCanonical, canonicalIndex),
123+
[subBlocksForCanonical, canonicalIndex]
124124
)
125125

126126
// Get subblock layout using custom hook

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/hooks/use-editor-subblock-layout.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,13 @@ export function useEditorSubblockLayout(
8787
{}
8888
)
8989

90-
const canonicalIndex = buildCanonicalIndex(config.subBlocks || [])
90+
const subBlocksForCanonical = displayTriggerMode
91+
? (config.subBlocks || []).filter(
92+
(subBlock) =>
93+
subBlock.mode === 'trigger' || subBlock.type === ('trigger-config' as SubBlockType)
94+
)
95+
: config.subBlocks || []
96+
const canonicalIndex = buildCanonicalIndex(subBlocksForCanonical)
9197
const effectiveAdvanced = displayAdvancedMode
9298
const canonicalModeOverrides = blockData?.canonicalModes
9399

0 commit comments

Comments
 (0)