add FF lint checks

Author: icecrasher321

.github/workflows/test-build.yml

@@ -41,20 +41,33 @@ jobs:
       - name: Validate feature flags
         run: |
           FILE="apps/sim/lib/core/config/feature-flags.ts"
-          echo "Checking for hardcoded boolean feature flags in $FILE..."
+          ERRORS=""
 
-          # Find any "export const isXxx = true" or "export const isXxx = false" patterns
-          # This catches accidental local testing values being committed
-          if grep -E "export const is[A-Za-z]+\s*=\s*(true|false)\s*;?\s*$" "$FILE"; then
-            echo ""
-            echo "❌ ERROR: Feature flags must not be hardcoded to boolean literals!"
-            echo "Feature flags should derive their values from environment variables."
-            echo ""
-            echo "Example of what NOT to do:"
-            echo "  export const isHosted = true"
+          echo "Checking for hardcoded boolean feature flags..."
+
+          # Use perl for multiline matching to catch both:
+          #   export const isHosted = true
+          #   export const isHosted =
+          #     true
+          HARDCODED=$(perl -0777 -ne 'while (/export const (is[A-Za-z]+)\s*=\s*\n?\s*(true|false)\b/g) { print "  $1 = $2\n" }' "$FILE")
+
+          if [ -n "$HARDCODED" ]; then
+            ERRORS="${ERRORS}\n❌ Feature flags must not be hardcoded to boolean literals!\n\nFound hardcoded flags:\n${HARDCODED}\n\nFeature flags should derive their values from environment variables.\n"
+          fi
+
+          echo "Checking feature flag naming conventions..."
+
+          # Check that all export const (except functions) start with 'is'
+          # This finds exports like "export const someFlag" that don't start with "is" or "get"
+          BAD_NAMES=$(grep -E "^export const [a-z]" "$FILE" | grep -vE "^export const (is|get)" | sed 's/export const \([a-zA-Z]*\).*/  \1/')
+
+          if [ -n "$BAD_NAMES" ]; then
+            ERRORS="${ERRORS}\n❌ Feature flags must use 'is' prefix for boolean flags!\n\nFound incorrectly named flags:\n${BAD_NAMES}\n\nExample: 'hostedMode' should be 'isHostedMode'\n"
+          fi
+
+          if [ -n "$ERRORS" ]; then
             echo ""
-            echo "Example of correct implementation:"
-            echo "  export const isHosted = getEnv('NEXT_PUBLIC_APP_URL') === 'https://www.sim.ai'"
+            echo -e "$ERRORS"
             exit 1
           fi