Skip to content

Commit 8de7231

Browse files
committed
remove redunant if-else
1 parent 90def59 commit 8de7231

File tree

1 file changed

+3
-8
lines changed

1 file changed

+3
-8
lines changed

apps/sim/tools/params.ts

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -612,11 +612,12 @@ export function deepMergeInputMapping(
612612
}
613613

614614
// Deep merge: LLM values as base, user non-empty values override
615+
// If user provides empty object {}, LLM values fill all fields (intentional)
615616
const merged: Record<string, unknown> = { ...llmInputMapping }
616617

617618
for (const [key, userValue] of Object.entries(parsedUserMapping)) {
618619
// Only override LLM value if user provided a non-empty value
619-
// Note: Using strict inequality (===) so 0 and false are correctly preserved
620+
// Note: Using strict inequality (!==) so 0 and false are correctly preserved
620621
if (userValue !== undefined && userValue !== null && userValue !== '') {
621622
merged[key] = userValue
622623
}
@@ -642,13 +643,7 @@ export function mergeToolParameters(
642643
const filteredUserParams: Record<string, unknown> = {}
643644
for (const [key, value] of Object.entries(userProvidedParams)) {
644645
if (value !== undefined && value !== null && value !== '') {
645-
// Special handling for inputMapping: don't filter out empty objects
646-
// as we'll deep merge them later
647-
if (key === 'inputMapping') {
648-
filteredUserParams[key] = value
649-
} else {
650-
filteredUserParams[key] = value
651-
}
646+
filteredUserParams[key] = value
652647
}
653648
}
654649

0 commit comments

Comments
 (0)