ack PR comments

Author: waleedlatif1

apps/sim/tools/memory/add.ts

@@ -47,7 +47,10 @@ export const memoryAddTool: ToolConfig<any, MemoryResponse> = {
       }
 
       const conversationId = params.conversationId || params.id
-      const key = conversationId as string
+      if (!conversationId) {
+        throw new Error('conversationId or id is required')
+      }
+      const key = conversationId
 
       const body: Record<string, any> = {
         key,

apps/sim/tools/memory/delete.ts

@@ -30,6 +30,9 @@ export const memoryDeleteTool: ToolConfig<any, MemoryResponse> = {
       }
 
       const conversationId = params.conversationId || params.id
+      if (!conversationId) {
+        throw new Error('conversationId or id is required')
+      }
 
       const url = new URL('/api/memory', 'http://dummy')
       url.searchParams.set('workspaceId', workspaceId)

apps/sim/tools/memory/get.ts

@@ -30,7 +30,10 @@ export const memoryGetTool: ToolConfig<any, MemoryResponse> = {
       }
 
       const conversationId = params.conversationId || params.id
-      const query = conversationId as string
+      if (!conversationId) {
+        throw new Error('conversationId or id is required')
+      }
+      const query = conversationId
 
       const url = new URL('/api/memory', 'http://dummy')
       url.searchParams.set('workspaceId', workspaceId)