Skip to content

android: provide correct java path to check_javac_version #9908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ogoffart merged 1 commit into from
Nov 3, 2025
Merged

android: provide correct java path to check_javac_version #9908

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/backends/android-activity/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,8 @@ fn main() {

if !o.status.success() {
eprintln!("Dex conversion failed: {}", String::from_utf8_lossy(&o.stderr));
let javac = android_build::javac().unwrap();
let java_ver = android_build::check_javac_version(&javac).unwrap();
let java_home = android_build::java_home().unwrap();
let java_ver = android_build::check_javac_version(&java_home).unwrap();
if java_ver >= 21 {
eprintln!("WARNING: JDK version 21 is known to cause an error with older android SDK");
eprintln!("See https://github.com/slint-ui/slint/issues/4973");
Expand Down
Loading