Incorporated my flake8stats.txt with many more warnings. #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also ignore lines that are source file reports.
Adding a very large selection of flake8 results from a project that had never been refactored. The following flake8 plugins were enabled: flake8-aaa flake8-blind-except flake8-broken-line flake8-builtins flake8-class-attributes-order flake8-commas flake8-comments flake8-comprehensions flake8-docstrings flake8-dunder-all flake8-expression-complexity flake8-html flake8-if-expr flake8-import-order flake8-logging-format flake8-module-imports flake8-module-name flake8-pep3101 flake8-plugin-utils flake8-polyfill flake8-quotes flake8-raise flake8-rst-docstrings flake8-secure-coding-standard flake8-simplify flake8-string-format flake8-tuple flake8-type-annotations flake8-typehinting flake8-typing-imports pep8-naming
smarie
reviewed
Dec 15, 2021
| match = RE_TO_MATCH.match(line) | ||
| if not match: | ||
| warn("Line in Flake8 statistics report does not match template and will be ignored: %r" % line) | ||
| smatch = SOURCE_MATCH.match(line) |
Owner
There was a problem hiding this comment.
Thanks a lot @rnickle !
Could you please implement the suggestion I made in https://github.com/smarie/python-genbadge/pull/21/files#r751296939 and https://github.com/smarie/python-genbadge/pull/21/files#r751299039 ?
- putting the "if match" branch first
- adding a comment in each branch to explain and give an example of what is handled in that branch
This is to help future maintainers and editors :)
Thanks !
Owner
|
Hi @rnickle , did you get a chance to look at the above comment ? so that I can merge the pr afterwards and release :) |
Author
|
Forgive me, I did see it and I worked on it, but I didn't close on it. I will try to find some time this week!
Thank you,
Rick
…-- ***@***.***
________________________________
From: Sylvain Marié ***@***.***>
Sent: Saturday, March 12, 2022 9:16 AM
To: smarie/python-genbadge ***@***.***>
Cc: rnickle ***@***.***>; Mention ***@***.***>
Subject: Re: [smarie/python-genbadge] Incorporated my flake8stats.txt with many more warnings. (PR #22)
Hi @rnickle<https://github.com/rnickle> , did you get a chance to look at the above comment ? so that I can merge the pr afterwards and release :)
—
Reply to this email directly, view it on GitHub<#22 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AHZ3SAWIWF6BAFKKCPI6WWTU7SRKDANCNFSM5J3XZJJQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Owner
|
Thanks ! No rush of course. I just thought that this PR was valuable and it was sad not to have it merged yet :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 98 additional flake8stats messages to the test, and updated the test
to pass with the new numbers.