Skip to content

Add freshly fetched configs from config poller #1441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ogtownsend wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add freshly fetched configs from config poller #1441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3bda839
Add freshly fetched configs from config poller
ogtownsend Dec 3, 2025
fba7d4c
fix typo
ogtownsend Dec 3, 2025
9862257
Merge branch 'main' into ogt/log-configs-fetched-config-poller
ogtownsend Dec 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/chainaccessor/default_accessor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ func (l *DefaultAccessor) GetAllConfigsLegacy(
var configRequests contractreader.ExtendedBatchGetLatestValuesRequest
var standardOffRampRequestCount int
if l.chainSelector == destChainSelector {
lggr.Debugw("getting ChainConfigSnapshot and and OffRamp SourceChainConfigs for destination chain")
lggr.Debugw("getting ChainConfigSnapshot and OffRamp SourceChainConfigs for destination chain")
configRequests, standardOffRampRequestCount = prepareDestChainRequest(sourceChainSelectors)
} else {
lggr.Debugw("getting ChainConfigSnapshot for a source chain")
Expand Down
7 changes: 6 additions & 1 deletion pkg/reader/config_poller_v2.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,7 +428,12 @@ func (c *configPollerV2) batchRefreshChainAndSourceConfigs(
"sourceChainSelectors", sourceChainSelectors,
)
}
c.lggr.Debugw("Batch refreshed configs via chainAccessor", "chain", chainSel, "latency", time.Since(start))
c.lggr.Debugw("Batch refreshed configs via chainAccessor",
"chain", chainSel,
"latency", time.Since(start),
"chainConfigSnapshot", chainConfigSnapshot,
Copy link

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logging potentially sensitive configuration data at debug level could expose internal system details in production logs. Consider whether this data contains sensitive information (API keys, private endpoints, etc.) that should not be logged, or restrict this logging to trace level instead of debug level.

Suggested change
"chainConfigSnapshot", chainConfigSnapshot,
"chainConfigSnapshot", chainConfigSnapshot,
)
c.lggr.Tracew("Batch refreshed sourceChainConfigs via chainAccessor",
"chain", chainSel,

Copilot uses AI. Check for mistakes.
"sourceChainConfigs", sourceChainConfigs,
)
return nil
}

Expand Down
Loading