From 05b606b59a7f7ef0c51417b09929f8efc6552321 Mon Sep 17 00:00:00 2001 From: Prashant Yadav Date: Thu, 26 Feb 2026 21:12:52 -0800 Subject: [PATCH 1/2] Remove vault.secrets.get endpoint from gateway --- core/services/gateway/handlers/vault/handler.go | 9 --------- system-tests/tests/smoke/cre/v2_vault_don_test.go | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/core/services/gateway/handlers/vault/handler.go b/core/services/gateway/handlers/vault/handler.go index d5580dd0128..730eaaa6e85 100644 --- a/core/services/gateway/handlers/vault/handler.go +++ b/core/services/gateway/handlers/vault/handler.go @@ -357,15 +357,6 @@ func (h *handler) HandleJSONRPCUserMessage(ctx context.Context, req jsonrpc.Requ } h.lggr.Debugw("returning cached public key response") return h.handlePublicKeyGetSynchronously(ctx, req, publicKeyResponseBytes, callback) - - case vaulttypes.MethodSecretsGet: - // Secrets get is only allowed in non-production builds for testing purposes - // So no authorization is required - ar, err := h.newActiveRequest(req, callback) - if err != nil { - return err - } - return h.handleSecretsGet(ctx, ar) } isAuthorized, owner, err := h.requestAuthorizer.AuthorizeRequest(ctx, req) diff --git a/system-tests/tests/smoke/cre/v2_vault_don_test.go b/system-tests/tests/smoke/cre/v2_vault_don_test.go index 83fcdca0515..8aa78aad8f7 100644 --- a/system-tests/tests/smoke/cre/v2_vault_don_test.go +++ b/system-tests/tests/smoke/cre/v2_vault_don_test.go @@ -89,7 +89,7 @@ func ExecuteVaultTest(t *testing.T, testEnv *ttypes.TestEnvironment) { framework.L.Info().Msg("Waiting 30 seconds for the Vault DON to be ready...") time.Sleep(30 * time.Second) executeVaultSecretsCreateTest(t, encryptedSecret, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) - executeVaultSecretsGetTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) + // executeVaultSecretsGetTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) executeVaultSecretsUpdateTest(t, encryptedSecret, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) executeVaultSecretsListTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) executeVaultSecretsDeleteTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) From 3b1e12f60f0660d5ab15363ff075de79b5163eae Mon Sep 17 00:00:00 2001 From: Prashant Yadav Date: Thu, 26 Feb 2026 21:18:54 -0800 Subject: [PATCH 2/2] nit --- system-tests/tests/smoke/cre/v2_vault_don_test.go | 1 + 1 file changed, 1 insertion(+) diff --git a/system-tests/tests/smoke/cre/v2_vault_don_test.go b/system-tests/tests/smoke/cre/v2_vault_don_test.go index 8aa78aad8f7..73a253b897b 100644 --- a/system-tests/tests/smoke/cre/v2_vault_don_test.go +++ b/system-tests/tests/smoke/cre/v2_vault_don_test.go @@ -89,6 +89,7 @@ func ExecuteVaultTest(t *testing.T, testEnv *ttypes.TestEnvironment) { framework.L.Info().Msg("Waiting 30 seconds for the Vault DON to be ready...") time.Sleep(30 * time.Second) executeVaultSecretsCreateTest(t, encryptedSecret, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) + // Disable Get tests // executeVaultSecretsGetTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) executeVaultSecretsUpdateTest(t, encryptedSecret, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract) executeVaultSecretsListTest(t, secretID, ownerAddr, gatewayURL.String(), sethClient, wfRegistryContract)