Role support #2
Open
Role support #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After working with internal team, found this additional permission was needed to handle KMS key backed secrets. Allowing this in addition to @scott-hiemstra's 'Assumed' role changes gives us universal coverage.
Update ecs-roles-cf.json
dsperling
reviewed
Oct 28, 2022
| --env AWS_SESSION_TOKEN=$AWS_SESSION_TOKEN \ | ||
| smithmicro/ecs:latest create-cluster | ||
| smithmicro/ecs:latest create-cluster | ||
| unset AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY AWS_SESSION_TOKEN |
Member
There was a problem hiding this comment.
I would prefer not to show an unset here, even though it is good practice. It clutters the example IMHO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is simply a documentation change. It describes how to use a role for authentication instead of requiring an IAM user in the account.