Skip to content

Commit 5ba4d9e

Browse files
authored
Merge pull request #28 from smsapi/user-agent-fix
Fixes User-Agent header
2 parents 9072443 + d3d3721 commit 5ba4d9e

File tree

4 files changed

+32
-12
lines changed

4 files changed

+32
-12
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@ All notable changes to this project will be documented in this file.
44
The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
55

66
## [Unreleased]
7+
### Fixed
8+
- User-Agent header
79

810
## [3.0.0] - 2024-10-30
911

pom.xml

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,6 @@
4545
<artifactId>commons-codec</artifactId>
4646
<version>1.10</version>
4747
</dependency>
48-
<dependency>
49-
<groupId>org.apache.maven</groupId>
50-
<artifactId>maven-model</artifactId>
51-
<version>3.9.8</version>
52-
</dependency>
5348

5449
<!-- test -->
5550
<dependency>
@@ -67,6 +62,14 @@
6762
</dependencies>
6863

6964
<build>
65+
66+
<resources>
67+
<resource>
68+
<directory>src/main/resources-filtered</directory>
69+
<filtering>true</filtering>
70+
</resource>
71+
</resources>
72+
7073
<plugins>
7174

7275
<plugin>
@@ -150,6 +153,15 @@
150153
</configuration>
151154
</plugin>
152155

156+
<plugin>
157+
<groupId>org.apache.maven.plugins</groupId>
158+
<artifactId>maven-resources-plugin</artifactId>
159+
<version>3.3.1</version>
160+
<configuration>
161+
<propertiesEncoding>ISO-8859-1</propertiesEncoding>
162+
</configuration>
163+
</plugin>
164+
153165
</plugins>
154166
</build>
155167
</project>

src/main/java/pl/smsapi/proxy/ProxyNative.java

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,5 @@
11
package pl.smsapi.proxy;
22

3-
import org.apache.maven.model.Model;
4-
import org.apache.maven.model.io.xpp3.MavenXpp3Reader;
5-
import org.codehaus.plexus.util.xml.pull.XmlPullParserException;
63
import pl.smsapi.api.authenticationStrategy.AuthenticationStrategy;
74
import pl.smsapi.exception.ProxyException;
85

@@ -89,11 +86,19 @@ public String execute(String endpoint, Map<String, String> data, Map<String, Inp
8986
return response;
9087
}
9188

92-
private String generateUserAgent() throws IOException, XmlPullParserException {
89+
private String generateUserAgent() throws IOException {
9390
if (userAgent == null) {
94-
MavenXpp3Reader reader = new MavenXpp3Reader();
95-
Model model = reader.read(new FileReader("pom.xml"));
96-
userAgent = "smsapi/java-client:" + model.getVersion() + ";java:" + System.getProperty("java.vm.version");
91+
String version = "undefined";
92+
try (InputStream propertiesResource = this.getClass().getClassLoader().getResourceAsStream("smsapi-java-client.properties")) {
93+
if (propertiesResource != null) {
94+
final Properties properties = new Properties();
95+
properties.load(propertiesResource);
96+
version = properties.getProperty("version", "undefined");
97+
}
98+
}
99+
userAgent =
100+
"smsapi/java-client:" + version + ";" +
101+
"java:" + System.getProperty("java.vm.version", "undefined");
97102
}
98103
return userAgent;
99104
}
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
version=${project.version}

0 commit comments

Comments
 (0)