Commit 178e8c9
authored
fix(iOS): Distinguish horizontal and vertical scroll in gesture failure requirements (#3420)
Fixes
#3302
Supersedes
#3304
## Description
This PR fixes the failure requirements for content pop gesture. The
changes introduced in #3265 fixed the immediate dismissing of screen
when scrolling on horizontal ScrollView, but at the same time introduced
a regression for vertical scrolling. Here, we apply the failure
requirement only if the ScrollView has horizontal scrolling.
## Changes
Updated `RNSScreenStack`'s
`gestureRecognizer:shouldRequireFailureOf:otherGestureRecognizer` to
check if ScrollView has horizontal scrolling.
### After changes
https://github.com/user-attachments/assets/de8bfdaa-aa9b-4c25-917e-2d631bc590df
## Testing
Use `Test1072`. Make sure to check custom animations with `animation`
and `animationMatchesGesture`.1 parent 386854f commit 178e8c9
1 file changed
+13
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1152 | 1152 | | |
1153 | 1153 | | |
1154 | 1154 | | |
| 1155 | + | |
| 1156 | + | |
| 1157 | + | |
| 1158 | + | |
| 1159 | + | |
| 1160 | + | |
| 1161 | + | |
| 1162 | + | |
1155 | 1163 | | |
1156 | 1164 | | |
1157 | 1165 | | |
| |||
1253 | 1261 | | |
1254 | 1262 | | |
1255 | 1263 | | |
1256 | | - | |
| 1264 | + | |
| 1265 | + | |
| 1266 | + | |
| 1267 | + | |
1257 | 1268 | | |
1258 | 1269 | | |
1259 | 1270 | | |
| |||
1276 | 1287 | | |
1277 | 1288 | | |
1278 | 1289 | | |
| 1290 | + | |
1279 | 1291 | | |
1280 | 1292 | | |
1281 | 1293 | | |
| |||
0 commit comments