feat: add snapshotAfterUpdates property to RNSScreenView
#3296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkafar
changed the title
snapshotAfterUpdates property to RNSScreenViewsnapshotAfterUpdates property to RNSScreenView
kkafar
approved these changes
Nov 4, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Thanks.
I've updated PR description.
Let's wait for the CI to pass & we'll land it.
github-merge-queue bot
pushed a commit
to software-mansion/react-native-reanimated
that referenced
this pull request
Dec 3, 2025
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please follow the template so that the reviewers can easily understand what the code changes affect. --> ## Summary This PR brings back the Shared Element Transition feature to reanimated (within a limited scope and behind a feature flag). Current limitations: - animations with native modals don't work on iOS (the modal is displayed over the Shared Element). This can be fixed by plugging the Shared Element into the Window, instead of the React's RootVIew. - can't define custom progress (swipe back) transitions (it just isn't implemented yet, it was easier to hard code) - progress transitions animate less props than basic ones (for the same reason as above) - on iOS there are still some issues with header height (e.g. the `[SET] Modals`) example - there are some performance bottlenecks, that stem from transforms being recalculated too eagerly (this requires some changes to how we recognize whether to start a transition) - we have to use a workaround for rnscreens to not keep a snapshot of the transitioning view on the popped screen. Currently the [fix](software-mansion/react-native-screens#3296) is available in their nightly release. - zIndex of exiting animations changes (they are brought to the front). This differs from the current behaviour. - sometimes on a fast refresh, the transition will run for elements that are on the same screen. From our testing it happened when the navigator was wrapped with a context provider, but we didn't investigate it further. The problem was, that in this case the native view that represents the screen actually changed, so the SET logic worked as it should. But it definitely is not the expected outcome ## Test plan <!-- Provide a minimal but complete code snippet that can be used to test out this change along with instructions how to run it and a description of the expected behavior. --> --------- Co-authored-by: Krzysztof Piaskowy <krzysztof.piaskowy@swmansion.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add
snapshotAfterUpdatesproperty toRNSScreenView. This is done for the sake of integration withreanimated(SETs), wherereaniamtedneeds to make sure that some of the updates are applied before we take the snapshot.Caution
This is not a part of public API, rather an internal one.
Test code and steps to reproduce
The default behaviour should be as before - if not modified, the snapshot should be taken before view updates.
Checklist