fix: replace 30 bare cd commands with VERIFY_REPO-aware defaults across all waves

sjarmak · claude · sjarmak · commit 9ad2d84e222d · 2026-02-22T00:58:00.000Z
Sanity check of Wave 3 caught 9 missed bare `cd /app/repo` and `cd /workspace`
in ccb_build. Extended sweep to Waves 1-2 found 21 more in ccb_design (8),
ccb_debug (5), ccb_test (8). All replaced with `cd "${VERIFY_REPO:-/path}"` for
artifact-mode compatibility. Also fixed `git config safe.directory` in 8
code-review tasks.

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/benchmarks/ccb_build/cgen-deps-install-001/tests/test.sh b/benchmarks/ccb_build/cgen-deps-install-001/tests/test.sh
@@ -14,7 +14,7 @@ fi
 REWARD_FILE="/logs/verifier/reward.txt"
 mkdir -p /logs/verifier
 
-cd /app/repo
+cd "${VERIFY_REPO:-/app/repo}"
 
 python3 << 'EOF'
 import sys
diff --git a/benchmarks/ccb_build/codecoverage-deps-install-001/tests/test.sh b/benchmarks/ccb_build/codecoverage-deps-install-001/tests/test.sh
@@ -14,7 +14,7 @@ fi
 REWARD_FILE="/logs/verifier/reward.txt"
 mkdir -p /logs/verifier
 
-cd /app/repo
+cd "${VERIFY_REPO:-/app/repo}"
 
 python3 << 'EOF'
 import sys
diff --git a/benchmarks/ccb_build/dotenv-expand-deps-install-001/tests/test.sh b/benchmarks/ccb_build/dotenv-expand-deps-install-001/tests/test.sh
@@ -14,7 +14,7 @@ fi
 REWARD_FILE="/logs/verifier/reward.txt"
 mkdir -p /logs/verifier
 
-cd /app/repo
+cd "${VERIFY_REPO:-/app/repo}"
 
 python3 << 'EOF'
 import sys
diff --git a/benchmarks/ccb_build/dotnetkoans-deps-install-001/tests/test.sh b/benchmarks/ccb_build/dotnetkoans-deps-install-001/tests/test.sh
@@ -14,7 +14,7 @@ fi
 REWARD_FILE="/logs/verifier/reward.txt"
 mkdir -p /logs/verifier
 
-cd /app/repo
+cd "${VERIFY_REPO:-/app/repo}"
 
 python3 << 'EOF'
 import sys
diff --git a/benchmarks/ccb_build/eslint-markdown-deps-install-001/tests/test.sh b/benchmarks/ccb_build/eslint-markdown-deps-install-001/tests/test.sh
@@ -14,7 +14,7 @@ fi
 REWARD_FILE="/logs/verifier/reward.txt"
 mkdir -p /logs/verifier
 
-cd /app/repo
+cd "${VERIFY_REPO:-/app/repo}"
 
 python3 << 'EOF'
 import sys
diff --git a/benchmarks/ccb_build/iamactionhunter-deps-install-001/tests/test.sh b/benchmarks/ccb_build/iamactionhunter-deps-install-001/tests/test.sh
@@ -14,7 +14,7 @@ fi
 REWARD_FILE="/logs/verifier/reward.txt"
 mkdir -p /logs/verifier
 
-cd /app/repo
+cd "${VERIFY_REPO:-/app/repo}"
 
 python3 << 'EOF'
 import sys
diff --git a/benchmarks/ccb_build/pcap-parser-deps-install-001/tests/test.sh b/benchmarks/ccb_build/pcap-parser-deps-install-001/tests/test.sh
@@ -14,7 +14,7 @@ fi
 REWARD_FILE="/logs/verifier/reward.txt"
 mkdir -p /logs/verifier
 
-cd /app/repo
+cd "${VERIFY_REPO:-/app/repo}"
 
 python3 << 'EOF'
 import sys
diff --git a/benchmarks/ccb_build/similar-asserts-deps-install-001/tests/test.sh b/benchmarks/ccb_build/similar-asserts-deps-install-001/tests/test.sh
@@ -14,7 +14,7 @@ fi
 REWARD_FILE="/logs/verifier/reward.txt"
 mkdir -p /logs/verifier
 
-cd /app/repo
+cd "${VERIFY_REPO:-/app/repo}"
 
 python3 << 'EOF'
 import sys
diff --git a/benchmarks/ccb_build/vscode-stale-diagnostics-feat-001/tests/test.sh b/benchmarks/ccb_build/vscode-stale-diagnostics-feat-001/tests/test.sh
@@ -142,7 +142,7 @@ if [ -f "extensions/typescript-language-features/package.json" ]; then
     # VS Code extensions use npm test or a custom test runner
     cd extensions/typescript-language-features
     npm test 2>/logs/verifier/test_errors.txt && TEST_RC=0 || TEST_RC=$?
-    cd /workspace
+    cd "${VERIFY_REPO:-/workspace}"
     if [ "$TEST_RC" -eq 0 ]; then
         echo "[x] TypeScript language features tests passed"
     else
diff --git a/benchmarks/ccb_debug/linux-acpi-backlight-fault-001/tests/test.sh b/benchmarks/ccb_debug/linux-acpi-backlight-fault-001/tests/test.sh
@@ -9,7 +9,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
diff --git a/benchmarks/ccb_debug/linux-hda-intel-suspend-fault-001/tests/test.sh b/benchmarks/ccb_debug/linux-hda-intel-suspend-fault-001/tests/test.sh
@@ -9,7 +9,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
diff --git a/benchmarks/ccb_debug/linux-iwlwifi-subdevice-fault-001/tests/test.sh b/benchmarks/ccb_debug/linux-iwlwifi-subdevice-fault-001/tests/test.sh
@@ -9,7 +9,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
diff --git a/benchmarks/ccb_debug/linux-nfs-inode-revalidate-fault-001/tests/test.sh b/benchmarks/ccb_debug/linux-nfs-inode-revalidate-fault-001/tests/test.sh
@@ -9,7 +9,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
diff --git a/benchmarks/ccb_debug/linux-ssd-trim-timeout-fault-001/tests/test.sh b/benchmarks/ccb_debug/linux-ssd-trim-timeout-fault-001/tests/test.sh
@@ -9,7 +9,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
diff --git a/benchmarks/ccb_design/camel-routing-arch-001/tests/test.sh b/benchmarks/ccb_design/camel-routing-arch-001/tests/test.sh
@@ -11,7 +11,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
diff --git a/benchmarks/ccb_design/django-orm-query-arch-001/tests/test.sh b/benchmarks/ccb_design/django-orm-query-arch-001/tests/test.sh
@@ -11,7 +11,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
diff --git a/benchmarks/ccb_design/flink-checkpoint-arch-001/tests/test.sh b/benchmarks/ccb_design/flink-checkpoint-arch-001/tests/test.sh
@@ -11,7 +11,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
diff --git a/benchmarks/ccb_design/k8s-crd-lifecycle-arch-001/tests/test.sh b/benchmarks/ccb_design/k8s-crd-lifecycle-arch-001/tests/test.sh
@@ -11,7 +11,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
diff --git a/benchmarks/ccb_design/k8s-scheduler-arch-001/tests/test.sh b/benchmarks/ccb_design/k8s-scheduler-arch-001/tests/test.sh
@@ -11,7 +11,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
diff --git a/benchmarks/ccb_design/kafka-flink-streaming-arch-001/tests/test.sh b/benchmarks/ccb_design/kafka-flink-streaming-arch-001/tests/test.sh
@@ -11,7 +11,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 mkdir -p /logs/verifier
 
 # Fix git safe.directory for both repos
diff --git a/benchmarks/ccb_design/postgres-query-exec-arch-001/tests/test.sh b/benchmarks/ccb_design/postgres-query-exec-arch-001/tests/test.sh
@@ -11,7 +11,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
diff --git a/benchmarks/ccb_design/quantlib-barrier-pricing-arch-001/tests/test.sh b/benchmarks/ccb_design/quantlib-barrier-pricing-arch-001/tests/test.sh
@@ -11,7 +11,7 @@ if [ -f /tmp/.artifact_only_mode ] && [ -f /tests/answer_json_verifier_lib.sh ];
     source /tests/answer_json_verifier_lib.sh
 fi
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
diff --git a/benchmarks/ccb_test/aspnetcore-code-review-001/tests/test.sh b/benchmarks/ccb_test/aspnetcore-code-review-001/tests/test.sh
@@ -16,13 +16,13 @@ fi
 [ -f /tests/artifact_verifier_lib.sh ] && source /tests/artifact_verifier_lib.sh
 VERIFY_REPO="${VERIFY_REPO:-/workspace}"
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
-git config --global --add safe.directory /workspace 2>/dev/null || true
+git config --global --add safe.directory "${VERIFY_REPO:-/workspace}" 2>/dev/null || true
 git config --global --add safe.directory "${VERIFY_REPO}" 2>/dev/null || true
 
 # Guard: check agent produced output
diff --git a/benchmarks/ccb_test/calcom-code-review-001/tests/test.sh b/benchmarks/ccb_test/calcom-code-review-001/tests/test.sh
@@ -16,13 +16,13 @@ fi
 [ -f /tests/artifact_verifier_lib.sh ] && source /tests/artifact_verifier_lib.sh
 VERIFY_REPO="${VERIFY_REPO:-/workspace}"
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
-git config --global --add safe.directory /workspace 2>/dev/null || true
+git config --global --add safe.directory "${VERIFY_REPO:-/workspace}" 2>/dev/null || true
 git config --global --add safe.directory "${VERIFY_REPO}" 2>/dev/null || true
 
 # Guard: check agent produced output
diff --git a/benchmarks/ccb_test/curl-security-review-001/tests/test.sh b/benchmarks/ccb_test/curl-security-review-001/tests/test.sh
@@ -17,13 +17,13 @@ fi
 [ -f /tests/artifact_verifier_lib.sh ] && source /tests/artifact_verifier_lib.sh
 VERIFY_REPO="${VERIFY_REPO:-/workspace}"
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
-git config --global --add safe.directory /workspace 2>/dev/null || true
+git config --global --add safe.directory "${VERIFY_REPO:-/workspace}" 2>/dev/null || true
 git config --global --add safe.directory "${VERIFY_REPO}" 2>/dev/null || true
 
 # Guard: check agent produced output
diff --git a/benchmarks/ccb_test/envoy-code-review-001/tests/test.sh b/benchmarks/ccb_test/envoy-code-review-001/tests/test.sh
@@ -16,13 +16,13 @@ fi
 [ -f /tests/artifact_verifier_lib.sh ] && source /tests/artifact_verifier_lib.sh
 VERIFY_REPO="${VERIFY_REPO:-/workspace}"
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
-git config --global --add safe.directory /workspace 2>/dev/null || true
+git config --global --add safe.directory "${VERIFY_REPO:-/workspace}" 2>/dev/null || true
 git config --global --add safe.directory "${VERIFY_REPO}" 2>/dev/null || true
 
 # Guard: check agent produced output
diff --git a/benchmarks/ccb_test/ghost-code-review-001/tests/test.sh b/benchmarks/ccb_test/ghost-code-review-001/tests/test.sh
@@ -16,13 +16,13 @@ fi
 [ -f /tests/artifact_verifier_lib.sh ] && source /tests/artifact_verifier_lib.sh
 VERIFY_REPO="${VERIFY_REPO:-/workspace}"
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
-git config --global --add safe.directory /workspace 2>/dev/null || true
+git config --global --add safe.directory "${VERIFY_REPO:-/workspace}" 2>/dev/null || true
 git config --global --add safe.directory "${VERIFY_REPO}" 2>/dev/null || true
 
 # Guard: check agent produced output
diff --git a/benchmarks/ccb_test/kafka-security-review-001/tests/test.sh b/benchmarks/ccb_test/kafka-security-review-001/tests/test.sh
@@ -17,13 +17,13 @@ fi
 [ -f /tests/artifact_verifier_lib.sh ] && source /tests/artifact_verifier_lib.sh
 VERIFY_REPO="${VERIFY_REPO:-/workspace}"
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
-git config --global --add safe.directory /workspace 2>/dev/null || true
+git config --global --add safe.directory "${VERIFY_REPO:-/workspace}" 2>/dev/null || true
 git config --global --add safe.directory "${VERIFY_REPO}" 2>/dev/null || true
 
 # Guard: check agent produced output
diff --git a/benchmarks/ccb_test/terraform-code-review-001/tests/test.sh b/benchmarks/ccb_test/terraform-code-review-001/tests/test.sh
@@ -16,13 +16,13 @@ fi
 [ -f /tests/artifact_verifier_lib.sh ] && source /tests/artifact_verifier_lib.sh
 VERIFY_REPO="${VERIFY_REPO:-/workspace}"
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
-git config --global --add safe.directory /workspace 2>/dev/null || true
+git config --global --add safe.directory "${VERIFY_REPO:-/workspace}" 2>/dev/null || true
 git config --global --add safe.directory "${VERIFY_REPO}" 2>/dev/null || true
 
 # Guard: check agent produced output
diff --git a/benchmarks/ccb_test/vscode-code-review-001/tests/test.sh b/benchmarks/ccb_test/vscode-code-review-001/tests/test.sh
@@ -16,13 +16,13 @@ fi
 [ -f /tests/artifact_verifier_lib.sh ] && source /tests/artifact_verifier_lib.sh
 VERIFY_REPO="${VERIFY_REPO:-/workspace}"
 
-cd /workspace
+cd "${VERIFY_REPO:-/workspace}"
 
 # Create log directories
 mkdir -p /logs/verifier
 
 # Fix git safe.directory
-git config --global --add safe.directory /workspace 2>/dev/null || true
+git config --global --add safe.directory "${VERIFY_REPO:-/workspace}" 2>/dev/null || true
 git config --global --add safe.directory "${VERIFY_REPO}" 2>/dev/null || true
 
 # Guard: check agent produced output
