style: detekt

Author: BFergerson

detekt.yml

@@ -2,7 +2,7 @@
 # https://github.com/detekt/detekt/blob/master/detekt-core/src/main/resources/default-detekt-config.yml
 
 build:
-  maxIssues: 8 #todo: zero out
+  maxIssues: 6 #todo: zero out
 
 formatting:
   Indentation:
@@ -41,6 +41,10 @@ exceptions:
     excludes: [ '**/test/**' ]
 
 complexity:
+  NestedBlockDepth:
+    threshold: 5
+  TooManyFunctions:
+    thresholdInClasses: 15
   LongParameterList:
     functionThreshold: 8
   LongMethod:

src/main/kotlin/spp/cli/Main.kt

@@ -44,7 +44,7 @@ import spp.cli.commands.developer.view.SubscribeView
 
 object Main {
 
-    lateinit var args: Array<String>
+    private lateinit var args: Array<String>
 
     @JvmStatic
     fun main(args: Array<String>) {

src/main/kotlin/spp/cli/util/ExitManager.kt

@@ -41,7 +41,7 @@ object ExitManager {
     fun exitProcess(e: List<Error>): Nothing {
         echo(e[0].message, err = true)
         if (standalone) exitProcess(-1)
-        throw Exception(e[0].message)
+        throw IllegalStateException(e[0].message)
     }
 
     private fun echo(

src/test/kotlin/integration/CLIIntegrationTest.kt

@@ -28,7 +28,7 @@ import java.io.OutputStream
 import java.io.PrintStream
 import kotlin.reflect.KClass
 
-abstract class CLIIntegrationTest {
+open class CLIIntegrationTest {
     companion object {
         init {
             ExitManager.standalone = false