support volume expansion

[lijhnihaoa]

I would like to ask what you think about the high availability of CSI. For example, if SPDK and CSI-Node are restarted at the same time, how can they be restored to the state before the restart.

[cyb70289]

No strong feeling from me. But welcome contributions.

[lijhnihaoa]

I wonder if storing this information in etcd will affect the impact of the k8s cluster, if it is used in the actual production environment. etcd is generally the best memory in 8G, Too big or too small can easily cause performance degradation.I feel that my question is a bit redundant, but I still want to hear more professional opinions.

[lijhnihaoa]

If I want to contribute the code of expand volume, what should I do?

[cyb70289]

You can follow the guide in below link to setup gerrit and push code.
https://spdk.io/development/
Please note the guide refers to spdk repo, the spdk-csi repo is at https://review.spdk.io/spdk/spdk-csi.

[lijhnihaoa]

To https://review.spdk.io/spdk/spdk-csi ! [remote rejected] HEAD -> refs/for/master (commit de65fdf: not Signed-off-by author/committer/uploader in message footer) error: failed to push some refs to 'https://review.spdk.io/spdk/spdk-csi' What should I do?

[cyb70289]

not Signed-off-by author/committer/uploader in message footer

Try git commit --amend -s to add sign-off-by line.

[lijhnihaoa]

nice

[lijhnihaoa]

How often submitted code is generally evaluated

[cyb70289]

I've left comment to your PR yesterday.
Normally there will be response in a week. Not guaranteed if reviewer is busy or simply missed your patch.
If you'd like it to be faster, join spdk slack channel and ping reviewers directly. Comments in gerrit are often ignored by reviewers.
https://spdk.io/community/

[lijhnihaoa]

thank you . i got it

[cyb70289]

For a major feature, there's often non-trivial feed backs and change request to the original commit.

[lijhnihaoa]

I think mine is a secondary feature, haha.

[lijhnihaoa]

root@localhost:~/go/src/spdk-csi# git status
On branch master
Your branch is up to date with 'origin/master'.

Changes not staged for commit:
(use "git add ..." to update what will be committed)
(use "git restore ..." to discard changes in working directory)
modified: pkg/spdk/controllerserver.go
modified: pkg/util/iscsi.go
modified: pkg/util/iscsi_test.go
modified: pkg/util/jsonrpc.go
modified: pkg/util/nvmf.go
modified: pkg/util/nvmf_test.go
root@localhost:/go/src/spdk-csi# make test
=== runnng go mod verify
all modules verified
=== running unit test
? github.com/spdk/spdk-csi/cmd [no test files]
? github.com/spdk/spdk-csi/pkg/csi-common [no test files]
ok github.com/spdk/spdk-csi/pkg/spdk 6.478s coverage: 24.4% of statements
ok github.com/spdk/spdk-csi/pkg/util 1.410s coverage: 47.8% of statements
root@localhost:/go/src/spdk-csi#

I added functionality for volume expansion and performed unit tests. This indicate that the test passed?