Skip to content

Commit 73408b1

Browse files
committed
update bundler and minimize dependency scopes
also added a placeholder test
1 parent 13587f9 commit 73408b1

File tree

3 files changed

+27
-6
lines changed

3 files changed

+27
-6
lines changed

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
org.gradle.parallel=true
22

3-
spinnakerGradleVersion=7.5.2
3+
spinnakerGradleVersion=7.11.6
44
pf4jVersion=3.2.0
55
korkVersion=7.37.0
66
orcaVersion=8.3.0

spring-example-orca/spring-example-orca.gradle

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,14 @@ spinnakerPlugin {
2828
}
2929

3030
dependencies {
31-
compile "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
31+
compileOnly "org.jetbrains.kotlin:kotlin-stdlib-jdk8:$kotlin_version"
3232
compileOnly (group: 'org.springframework', name: 'spring-context', version: '5.2.1.RELEASE')
3333
compileOnly (group: 'com.netflix.spinnaker.kork', name: 'kork-plugins-spring-api', version: "${korkVersion}")
3434
compileOnly (group: 'org.springframework', name: 'spring-web', version: '5.2.2.RELEASE')
35-
compileOnly (group: 'com.netflix.spinnaker.orca', name: 'orca-core', version: "${orcaVersion}") {
36-
exclude group: "org.slf4j"
37-
}
38-
implementation group: 'org.slf4j', name: 'slf4j-api', version: '1.7.28'
35+
compileOnly (group: 'com.netflix.spinnaker.orca', name: 'orca-core', version: "${orcaVersion}")
36+
37+
38+
testImplementation (group: 'com.netflix.spinnaker.orca', name: 'orca-core', version: "${orcaVersion}")
3939

4040
testImplementation "org.junit.jupiter:junit-jupiter-api:5.3.2"
4141
testImplementation group: 'io.strikt', name: 'strikt-core', version: '0.22.1'
Lines changed: 21 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,21 @@
1+
package io.armory.plugin.example.spring
2+
3+
import com.netflix.spinnaker.orca.capabilities.CapabilitiesService
4+
import dev.minutest.junit.JUnit5Minutests
5+
import dev.minutest.rootContext
6+
import strikt.api.expectThat
7+
import strikt.assertions.isEqualTo
8+
9+
class NewServiceTest : JUnit5Minutests {
10+
11+
class StubCapabilitiesService : CapabilitiesService(null, null)
12+
13+
fun tests() = rootContext {
14+
test("execute new service") {
15+
expectThat(NewService(StubCapabilitiesService(), NewProperties()).test())
16+
.isEqualTo(
17+
listOf("new service", "works")
18+
)
19+
}
20+
}
21+
}

0 commit comments

Comments
 (0)