Merge pull request #840 from splitio/master

gthea · web-flow · commit ec43f8582dc7 · 2026-02-24T12:04:02.000-03:00
Update development branch
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -1,3 +1,6 @@
+3.7.1: (Feb 19, 2026)
+- Improved impressions persistence and submission.
+
 3.7.0: (Jan 28, 2026)
 - Added functionality to provide metadata alongside SDK update and READY events. Read more in our docs.
 
diff --git a/NOTICE b/NOTICE
@@ -1,4 +1,4 @@
-Harness Feature Management JavaScript SDK Copyright 2024-2026 Harness Inc.
+Harness Feature Management iOS SDK Copyright 2024-2026 Harness Inc.
 
 This product includes software developed at Harness Inc. (https://harness.io/).
 
diff --git a/Split.podspec b/Split.podspec
@@ -1,7 +1,7 @@
 Pod::Spec.new do |s|
   s.name             = 'Split'
   s.module_name      = 'Split'
-  s.version          = '3.7.0'
+  s.version          = '3.7.1'
   s.summary          = 'iOS SDK for Split'
   s.description      = <<-DESC
 This SDK is designed to work with Split, the platform for controlled rollouts, serving features to your users via the Split feature flag to manage your complete customer experience.
diff --git a/Split/Common/Utils/Version.swift b/Split/Common/Utils/Version.swift
@@ -10,7 +10,7 @@ import Foundation
 class Version {
     private static let kSdkPlatform: String = "ios"
 
-    private static let kVersion = "3.7.0"
+    private static let kVersion = "3.7.1"
 
     static var semantic: String {
         return kVersion
diff --git a/Split/FetcherEngine/Recorder/ImpressionsRecorderWorker.swift b/Split/FetcherEngine/Recorder/ImpressionsRecorderWorker.swift
@@ -29,7 +29,7 @@ class ImpressionsRecorderWorker: RecorderWorker, @unchecked Sendable {
 
     func flush() {
         var rowCount = 0
-        var failedImpressions = [KeyImpression]()
+        var failedCount = 0
         repeat {
             let impressions = persistentImpressionsStorage.pop(count: impressionsPerPush)
             rowCount = impressions.count
@@ -42,18 +42,17 @@ class ImpressionsRecorderWorker: RecorderWorker, @unchecked Sendable {
                     Logger.i("Impressions posted successfully")
                 } catch let error {
                     Logger.e("Impression error: \(String(describing: error))")
-                    failedImpressions.append(contentsOf: impressions)
+                    // Impressions remain in DB for retry on next flush cycle
+                    failedCount = rowCount
+                    break
                 }
             }
         } while rowCount == impressionsPerPush
-        // Activate non sent impressions to retry in next iteration
-        persistentImpressionsStorage.setActive(failedImpressions)
         if let syncHelper = impressionsSyncHelper {
-            syncHelper.updateAccumulator(count: failedImpressions.count,
-                                         bytes: failedImpressions.count *
+            syncHelper.updateAccumulator(count: failedCount,
+                                         bytes: failedCount *
                                             ServiceConstants.estimatedImpressionSizeInBytes)
         }
-
     }
 
     private func group(impressions: [KeyImpression]) -> [ImpressionsTest] {
diff --git a/Split/Storage/Impressions/ImpressionDao.swift b/Split/Storage/Impressions/ImpressionDao.swift
@@ -51,7 +51,7 @@ class CoreDataImpressionDao: BaseCoreDataDao, ImpressionDao, @unchecked Sendable
                 return
             }
 
-            let predicate = NSPredicate(format: "createdAt >= %d AND status == %d", createdAt, status)
+            let predicate = NSPredicate(format: "createdAt >= %d", createdAt)
             let entities = self.coreDataHelper.fetch(entity: .impression,
                                                 where: predicate,
                                                 rowLimit: maxRows).compactMap { return $0 as? ImpressionEntity }
diff --git a/Split/Storage/Impressions/ImpressionEntity.swift b/Split/Storage/Impressions/ImpressionEntity.swift
@@ -15,6 +15,7 @@ class ImpressionEntity: NSManagedObject {
     @NSManaged public var storageId: String
     @NSManaged public var body: String
     @NSManaged public var createdAt: Int64
+    // status is not queried anymore, but we keep it for backward compatibility
     @NSManaged public var status: Int32
     @NSManaged public var testName: String
 }
diff --git a/Split/Storage/Impressions/PersistentImpressionsStorage.swift b/Split/Storage/Impressions/PersistentImpressionsStorage.swift
@@ -30,7 +30,6 @@ class DefaultImpressionsStorage: PersistentImpressionsStorage, @unchecked Sendab
     func pop(count: Int) -> [KeyImpression] {
         let createdAt = Date().unixTimestamp() - self.expirationPeriod
         let impressions = impressionDao.getBy(createdAt: createdAt, status: StorageRecordStatus.active, maxRows: count)
-        impressionDao.update(ids: impressions.compactMap { $0.storageId }, newStatus: StorageRecordStatus.deleted)
         return impressions
     }
 
diff --git a/SplitTests/Fake/Storage/PersistentImpressionsStorageStub.swift b/SplitTests/Fake/Storage/PersistentImpressionsStorageStub.swift
@@ -26,12 +26,7 @@ class PersistentImpressionsStorageStub: PersistentImpressionsStorage, @unchecked
     }
 
     func pop(count: Int) -> [KeyImpression] {
-        let deleted = impressionsStatus.filter { $0.value == StorageRecordStatus.deleted }.keys
-        let poped = Array(storedImpressions.values.filter { !deleted.contains($0.storageId ?? "") }.prefix(count))
-        for impression in poped {
-            impressionsStatus[impression.storageId ?? ""] = StorageRecordStatus.deleted
-        }
-        return poped
+        return Array(storedImpressions.values.prefix(count))
     }
 
     func push(impression: KeyImpression) {
diff --git a/SplitTests/Impressions/ImpressionsPropertiesE2ETest.swift b/SplitTests/Impressions/ImpressionsPropertiesE2ETest.swift
diff --git a/SplitTests/Service/Impressions/ImpressionsRecorderWorkerTests.swift b/SplitTests/Service/Impressions/ImpressionsRecorderWorkerTests.swift
diff --git a/SplitTests/Storage/ImpressionDaoTest.swift b/SplitTests/Storage/ImpressionDaoTest.swift
diff --git a/SplitTests/Storage/PersistentImpressionsStorageTest.swift b/SplitTests/Storage/PersistentImpressionsStorageTest.swift

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-Harness Feature Management JavaScript SDK Copyright 2024-2026 Harness Inc.`
	`1`	`+Harness Feature Management iOS SDK Copyright 2024-2026 Harness Inc.`
`2`	`2`
`3`	`3`	`This product includes software developed at Harness Inc. (https://harness.io/).`
`4`	`4`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ class CoreDataImpressionDao: BaseCoreDataDao, ImpressionDao, @unchecked Sendable`
`51`	`51`	`return`
`52`	`52`	`}`
`53`	`53`
`54`		`- let predicate = NSPredicate(format: "createdAt >= %d AND status == %d", createdAt, status)`
	`54`	`+ let predicate = NSPredicate(format: "createdAt >= %d", createdAt)`
`55`	`55`	`let entities = self.coreDataHelper.fetch(entity: .impression,`
`56`	`56`	`where: predicate,`
`57`	`57`	`rowLimit: maxRows).compactMap { return $0 as? ImpressionEntity }`
Original file line number	Diff line number	Diff line change
`@@ -15,6 +15,7 @@ class ImpressionEntity: NSManagedObject {`
`15`	`15`	`@NSManaged public var storageId: String`
`16`	`16`	`@NSManaged public var body: String`
`17`	`17`	`@NSManaged public var createdAt: Int64`
	`18`	`+ // status is not queried anymore, but we keep it for backward compatibility`
`18`	`19`	`@NSManaged public var status: Int32`
`19`	`20`	`@NSManaged public var testName: String`
`20`	`21`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,6 @@ class DefaultImpressionsStorage: PersistentImpressionsStorage, @unchecked Sendab`
`30`	`30`	`func pop(count: Int) -> [KeyImpression] {`
`31`	`31`	`let createdAt = Date().unixTimestamp() - self.expirationPeriod`
`32`	`32`	`let impressions = impressionDao.getBy(createdAt: createdAt, status: StorageRecordStatus.active, maxRows: count)`
`33`		`- impressionDao.update(ids: impressions.compactMap { $0.storageId }, newStatus: StorageRecordStatus.deleted)`
`34`	`33`	`return impressions`
`35`	`34`	`}`
`36`	`35`
Original file line number	Diff line number	Diff line change
`@@ -26,12 +26,7 @@ class PersistentImpressionsStorageStub: PersistentImpressionsStorage, @unchecked`
`26`	`26`	`}`
`27`	`27`
`28`	`28`	`func pop(count: Int) -> [KeyImpression] {`
`29`		`- let deleted = impressionsStatus.filter { $0.value == StorageRecordStatus.deleted }.keys`
`30`		`- let poped = Array(storedImpressions.values.filter { !deleted.contains($0.storageId ?? "") }.prefix(count))`
`31`		`- for impression in poped {`
`32`		`- impressionsStatus[impression.storageId ?? ""] = StorageRecordStatus.deleted`
`33`		`- }`
`34`		`- return poped`
	`29`	`+ return Array(storedImpressions.values.prefix(count))`
`35`	`30`	`}`
`36`	`31`
`37`	`32`	`func push(impression: KeyImpression) {`