Skip to content

Commit 821b706

Browse files
committed
Polish "Add compliance tests for settings.gradle"
See gh-1685
1 parent 7017565 commit 821b706

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

initializr-generator-spring/src/test/java/io/spring/initializr/generator/spring/build/gradle/GradleSettingsComplianceTests.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,8 @@
4646
*/
4747
class GradleSettingsComplianceTests extends AbstractComplianceTests {
4848

49+
private static final String BOOT_VERSION = "3.5.0";
50+
4951
static Stream<Arguments> parameters() {
5052
return Stream.of(new JavaLanguage(), new GroovyLanguage(), new KotlinLanguage())
5153
.flatMap((language) -> Stream.of(
@@ -58,15 +60,15 @@ static Stream<Arguments> parameters() {
5860
@ParameterizedTest
5961
@MethodSource("parameters")
6062
void defaultProjectSettings(Language language, BuildSystem build, String fileName) {
61-
ProjectStructure project = generateProject(language, build, "2.7.0");
63+
ProjectStructure project = generateProject(language, build, BOOT_VERSION);
6264
String path = "project/gradle/" + getAssertFileName(fileName);
6365
assertThat(project).textFile(fileName).as("Resource " + path).hasSameContentAs(new ClassPathResource(path));
6466
}
6567

6668
@ParameterizedTest
6769
@MethodSource("parameters")
6870
void customArtifactId(Language language, BuildSystem build, String fileName) {
69-
ProjectStructure project = generateProject(language, build, "2.7.0",
71+
ProjectStructure project = generateProject(language, build, BOOT_VERSION,
7072
(description) -> description.setArtifactId("my-project"));
7173
String path = "project/gradle/custom-artifact-id-" + getAssertFileName(fileName);
7274
assertThat(project).textFile(fileName).as("Resource " + path).hasSameContentAs(new ClassPathResource(path));
@@ -75,7 +77,7 @@ void customArtifactId(Language language, BuildSystem build, String fileName) {
7577
@ParameterizedTest
7678
@MethodSource("parameters")
7779
void pluginRepository(Language language, BuildSystem build, String fileName) {
78-
ProjectStructure project = generateProject(language, build, "2.7.0", (description) -> {
80+
ProjectStructure project = generateProject(language, build, BOOT_VERSION, (description) -> {
7981
}, (context) -> context.registerBean(BuildCustomizer.class,
8082
() -> (gradleBuild) -> gradleBuild.pluginRepositories()
8183
.add(MavenRepository.withIdAndUrl("spring-milestones", "https://repo.spring.io/milestone"))));
@@ -86,7 +88,7 @@ void pluginRepository(Language language, BuildSystem build, String fileName) {
8688
@ParameterizedTest
8789
@MethodSource("parameters")
8890
void pluginMapping(Language language, BuildSystem build, String fileName) {
89-
ProjectStructure project = generateProject(language, build, "2.7.0", (description) -> {
91+
ProjectStructure project = generateProject(language, build, BOOT_VERSION, (description) -> {
9092
}, (context) -> context.registerBean(BuildCustomizer.class,
9193
() -> (gradleBuild) -> ((GradleBuildSettings.Builder) gradleBuild.settings()).mapPlugin("com.example",
9294
Dependency.withCoordinates("com.example", "gradle-plugin")

0 commit comments

Comments
 (0)