Skip to content

Commit ce1a7fc

Browse files
ilayaperumalgmarkpollack
authored andcommitted
Remove default temperature option from the models
Remove hardcoded DEFAULT_TEMPERATURE values from autoconfiguration properties across all chat model providers. This allows each AI provider's native default temperature to be used when not explicitly configured. Update documentation to remove 0.7 default values from property tables and add upgrade notes for 2.0.0-M1 explaining the migration path. Fixes #5021 Signed-off-by: Ilayaperumal Gopinathan <ilayaperumal.gopinathan@broadcom.com>
1 parent 264fc3b commit ce1a7fc

File tree

18 files changed

+54
-51
lines changed

18 files changed

+54
-51
lines changed

auto-configurations/models/spring-ai-autoconfigure-model-anthropic/src/main/java/org/springframework/ai/model/anthropic/autoconfigure/AnthropicChatProperties.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ public class AnthropicChatProperties {
4242
private final AnthropicChatOptions options = AnthropicChatOptions.builder()
4343
.model(AnthropicChatModel.DEFAULT_MODEL_NAME)
4444
.maxTokens(AnthropicChatModel.DEFAULT_MAX_TOKENS)
45-
.temperature(AnthropicChatModel.DEFAULT_TEMPERATURE)
4645
.build();
4746

4847
public AnthropicChatOptions getOptions() {

auto-configurations/models/spring-ai-autoconfigure-model-azure-openai/src/main/java/org/springframework/ai/model/azure/openai/autoconfigure/AzureOpenAiChatProperties.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,9 @@ public class AzureOpenAiChatProperties {
2727

2828
public static final String DEFAULT_DEPLOYMENT_NAME = "gpt-4o";
2929

30-
private static final Double DEFAULT_TEMPERATURE = 0.7;
31-
3230
@NestedConfigurationProperty
3331
private final AzureOpenAiChatOptions options = AzureOpenAiChatOptions.builder()
3432
.deploymentName(DEFAULT_DEPLOYMENT_NAME)
35-
.temperature(DEFAULT_TEMPERATURE)
3633
.build();
3734

3835
public AzureOpenAiChatOptions getOptions() {

auto-configurations/models/spring-ai-autoconfigure-model-deepseek/src/main/java/org/springframework/ai/model/deepseek/autoconfigure/DeepSeekChatProperties.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,6 @@ public class DeepSeekChatProperties extends DeepSeekParentProperties {
3333

3434
public static final String DEFAULT_CHAT_MODEL = DeepSeekApi.ChatModel.DEEPSEEK_CHAT.getValue();
3535

36-
private static final Double DEFAULT_TEMPERATURE = 1D;
37-
3836
public static final String DEFAULT_COMPLETIONS_PATH = "/chat/completions";
3937

4038
public static final String DEFAULT_BETA_PREFIX_PATH = "/beta";
@@ -49,10 +47,7 @@ public class DeepSeekChatProperties extends DeepSeekParentProperties {
4947
private String betaPrefixPath = DEFAULT_BETA_PREFIX_PATH;
5048

5149
@NestedConfigurationProperty
52-
private final DeepSeekChatOptions options = DeepSeekChatOptions.builder()
53-
.model(DEFAULT_CHAT_MODEL)
54-
.temperature(DEFAULT_TEMPERATURE)
55-
.build();
50+
private final DeepSeekChatOptions options = DeepSeekChatOptions.builder().model(DEFAULT_CHAT_MODEL).build();
5651

5752
public DeepSeekChatOptions getOptions() {
5853
return this.options;

auto-configurations/models/spring-ai-autoconfigure-model-minimax/src/main/java/org/springframework/ai/model/minimax/autoconfigure/MiniMaxChatProperties.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,8 @@ public class MiniMaxChatProperties extends MiniMaxParentProperties {
3333

3434
public static final String DEFAULT_CHAT_MODEL = MiniMaxApi.ChatModel.ABAB_5_5_Chat.value;
3535

36-
private static final Double DEFAULT_TEMPERATURE = 0.7;
37-
3836
@NestedConfigurationProperty
39-
private final MiniMaxChatOptions options = MiniMaxChatOptions.builder()
40-
.model(DEFAULT_CHAT_MODEL)
41-
.temperature(DEFAULT_TEMPERATURE)
42-
.build();
37+
private final MiniMaxChatOptions options = MiniMaxChatOptions.builder().model(DEFAULT_CHAT_MODEL).build();
4338

4439
public MiniMaxChatOptions getOptions() {
4540
return this.options;

auto-configurations/models/spring-ai-autoconfigure-model-mistral-ai/src/main/java/org/springframework/ai/model/mistralai/autoconfigure/MistralAiChatProperties.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -37,16 +37,13 @@ public class MistralAiChatProperties extends MistralAiParentProperties {
3737

3838
public static final String DEFAULT_CHAT_MODEL = MistralAiApi.ChatModel.SMALL.getValue();
3939

40-
private static final Double DEFAULT_TEMPERATURE = 0.7;
41-
4240
private static final Double DEFAULT_TOP_P = 1.0;
4341

4442
private static final Boolean IS_ENABLED = false;
4543

4644
@NestedConfigurationProperty
4745
private final MistralAiChatOptions options = MistralAiChatOptions.builder()
4846
.model(DEFAULT_CHAT_MODEL)
49-
.temperature(DEFAULT_TEMPERATURE)
5047
.safePrompt(!IS_ENABLED)
5148
.topP(DEFAULT_TOP_P)
5249
.build();

auto-configurations/models/spring-ai-autoconfigure-model-oci-genai/src/main/java/org/springframework/ai/model/oci/genai/autoconfigure/OCICohereChatModelProperties.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,9 @@ public class OCICohereChatModelProperties {
3232

3333
private static final String DEFAULT_SERVING_MODE = ServingMode.ON_DEMAND.getMode();
3434

35-
private static final Double DEFAULT_TEMPERATURE = 0.7;
36-
3735
@NestedConfigurationProperty
3836
private final OCICohereChatOptions options = OCICohereChatOptions.builder()
3937
.servingMode(DEFAULT_SERVING_MODE)
40-
.temperature(DEFAULT_TEMPERATURE)
4138
.build();
4239

4340
public OCICohereChatOptions getOptions() {

auto-configurations/models/spring-ai-autoconfigure-model-openai-sdk/src/main/java/org/springframework/ai/model/openaisdk/autoconfigure/OpenAiSdkChatProperties.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,8 @@ public class OpenAiSdkChatProperties extends AbstractOpenAiSdkOptions {
3333

3434
public static final String DEFAULT_CHAT_MODEL = OpenAiSdkChatOptions.DEFAULT_CHAT_MODEL;
3535

36-
private static final Double DEFAULT_TEMPERATURE = 1.0;
37-
3836
@NestedConfigurationProperty
39-
private final OpenAiSdkChatOptions options = OpenAiSdkChatOptions.builder()
40-
.model(DEFAULT_CHAT_MODEL)
41-
.temperature(DEFAULT_TEMPERATURE)
42-
.build();
37+
private final OpenAiSdkChatOptions options = OpenAiSdkChatOptions.builder().model(DEFAULT_CHAT_MODEL).build();
4338

4439
public OpenAiSdkChatOptions getOptions() {
4540
return this.options;

auto-configurations/models/spring-ai-autoconfigure-model-openai/src/main/java/org/springframework/ai/model/openai/autoconfigure/OpenAiAudioTranscriptionProperties.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -28,14 +28,11 @@ public class OpenAiAudioTranscriptionProperties extends OpenAiParentProperties {
2828

2929
public static final String DEFAULT_TRANSCRIPTION_MODEL = OpenAiAudioApi.TranscriptionModels.WHISPER_1.getValue();
3030

31-
private static final Double DEFAULT_TEMPERATURE = 0.7;
32-
3331
private static final OpenAiAudioApi.TranscriptResponseFormat DEFAULT_RESPONSE_FORMAT = OpenAiAudioApi.TranscriptResponseFormat.TEXT;
3432

3533
@NestedConfigurationProperty
3634
private final OpenAiAudioTranscriptionOptions options = OpenAiAudioTranscriptionOptions.builder()
3735
.model(DEFAULT_TRANSCRIPTION_MODEL)
38-
.temperature(DEFAULT_TEMPERATURE.floatValue())
3936
.responseFormat(DEFAULT_RESPONSE_FORMAT)
4037
.build();
4138

auto-configurations/models/spring-ai-autoconfigure-model-zhipuai/src/main/java/org/springframework/ai/model/zhipuai/autoconfigure/ZhiPuAiChatProperties.java

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,13 +33,8 @@ public class ZhiPuAiChatProperties extends ZhiPuAiParentProperties {
3333

3434
public static final String DEFAULT_CHAT_MODEL = ZhiPuAiApi.ChatModel.GLM_4_Air.value;
3535

36-
private static final Double DEFAULT_TEMPERATURE = 0.7;
37-
3836
@NestedConfigurationProperty
39-
private final ZhiPuAiChatOptions options = ZhiPuAiChatOptions.builder()
40-
.model(DEFAULT_CHAT_MODEL)
41-
.temperature(DEFAULT_TEMPERATURE)
42-
.build();
37+
private final ZhiPuAiChatOptions options = ZhiPuAiChatOptions.builder().model(DEFAULT_CHAT_MODEL).build();
4338

4439
public ZhiPuAiChatOptions getOptions() {
4540
return this.options;

models/spring-ai-anthropic/src/main/java/org/springframework/ai/anthropic/AnthropicChatModel.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,8 +105,6 @@ public class AnthropicChatModel implements ChatModel {
105105

106106
public static final Integer DEFAULT_MAX_TOKENS = 500;
107107

108-
public static final Double DEFAULT_TEMPERATURE = 0.8;
109-
110108
private static final Logger logger = LoggerFactory.getLogger(AnthropicChatModel.class);
111109

112110
private static final ChatModelObservationConvention DEFAULT_OBSERVATION_CONVENTION = new DefaultChatModelObservationConvention();
@@ -991,7 +989,6 @@ public static final class Builder {
991989
private AnthropicChatOptions defaultOptions = AnthropicChatOptions.builder()
992990
.model(DEFAULT_MODEL_NAME)
993991
.maxTokens(DEFAULT_MAX_TOKENS)
994-
.temperature(DEFAULT_TEMPERATURE)
995992
.build();
996993

997994
private RetryTemplate retryTemplate = RetryUtils.DEFAULT_RETRY_TEMPLATE;

0 commit comments

Comments
 (0)