Unnecessary help display when completing commands

[piotrooo]

When a command description is not defined, we should not display N/A or empty parentheses ().

BTW, why are we displaying the text in parentheses (the grey one)? It seems to be duplicated.

[fmbenhassine]

The "N/A" is added because it is better than nothing. However, IIRC, we do not add (), this is a JLine thing.

[piotrooo]

Hmm, this looks inconsistent.

Commands created via @Bean (DSL) or by implementing the Command interface do not display "N/A" when the description is not provided.

Forcing an "N/A" value when the description is intentionally omitted feels unexpected.

[fmbenhassine]

I agree with you, this is inconsistent with the programmatic way of doing things. I will fix that.

However, just to make sure we are on the same page about "N/A": it stands for "Not Available" and not "Not Applicable". So I believe it has its place if the description is effectively not available. Now pragmatically speaking, intentionally omitting the description is a bad practice (I believe this is common sense and there is no need for references here.. but I really like this CLI Guidelines), and doing it to force an empty string is even worse. Seeing "N/A" in the description is better than guessing if the empty description is missing due any reason like a missing property, a non resolved SpEL expression, etc.

BTW, why are we displaying the text in parentheses (the grey one)? It seems to be duplicated.

They seem duplicated indeed, but they are not. One is the command's description, and the other is the command's help (see here). It just happens that built-in commands have very similar descriptions and help texts. And BTW, I was wrong about the (), it's not a JLine thing, we add them in the default method Command#getHelp(), my bad..

Anyway, showing the help between () does not seem to be a good choice as it can be a long text and not suitable to be shown there. I will remove that.